From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D4EC3A59F for ; Mon, 26 Aug 2019 22:14:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9824920828 for ; Mon, 26 Aug 2019 22:14:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726160AbfHZWOS (ORCPT ); Mon, 26 Aug 2019 18:14:18 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33753 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbfHZWOR (ORCPT ); Mon, 26 Aug 2019 18:14:17 -0400 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id 684F38231E; Tue, 27 Aug 2019 00:14:01 +0200 (CEST) Date: Tue, 27 Aug 2019 00:14:14 +0200 From: Pavel Machek To: Tony Lindgren Cc: Dan Murphy , jacek.anaszewski@gmail.com, sre@kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/5] leds: lm3532: Fix brightness control for i2c mode Message-ID: <20190826221413.GA19124@amd> References: <20190820195307.27590-1-dmurphy@ti.com> <20190826215822.GY52127@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6c2NcOVqGQ03X4Wi" Content-Disposition: inline In-Reply-To: <20190826215822.GY52127@atomide.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon 2019-08-26 14:58:22, Tony Lindgren wrote: > Hi, >=20 > * Dan Murphy [190820 19:53]: > > Fix the brightness control for I2C mode. Instead of > > changing the full scale current register update the ALS target > > register for the appropriate banks. > >=20 > > In addition clean up some code errors and random misspellings found > > during coding. > >=20 > > Tested on Droid4 as well as LM3532 EVM connected to a BeagleBoneBlack > >=20 > > Fixes: e37a7f8d77e1 ("leds: lm3532: Introduce the lm3532 LED driver") > > Reported-by: Pavel Machek > > Signed-off-by: Dan Murphy > > --- > >=20 > > v3 - Removed register define updates - https://lore.kernel.org/patchwor= k/patch/1114542/ >=20 > Looks like starting with this patch in Linux next the LCD on droid4 > is so dim it's unreadable even with brightness set to 255. Setting > brightness to 0 does blank it completely though. >=20 > Did something maybe break with the various patch revisions or are > we now missing some dts patch? Maybe missing dts patch. We should provide maximum current the LED can handle...=20 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --6c2NcOVqGQ03X4Wi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl1kWbUACgkQMOfwapXb+vIpSACdGammh0w/fbrIoKZZPYtqUFFI GdIAoJJmVqFlk0RrQOd58HsYi7PbAOaG =9ChQ -----END PGP SIGNATURE----- --6c2NcOVqGQ03X4Wi--