From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 2/2] leds: trigger: gpio: Convert to use kstrtox()
Date: Mon, 2 Sep 2019 13:08:02 +0300 [thread overview]
Message-ID: <20190902100802.GY2680@smile.fi.intel.com> (raw)
In-Reply-To: <20190901102316.GA29681@amd>
On Sun, Sep 01, 2019 at 12:23:17PM +0200, Pavel Machek wrote:
> On Fri 2019-08-30 18:08:20, Andy Shevchenko wrote:
> > sscanf() is a heavy one and moreover requires additional boundary checks.
> > Convert driver to use kstrtox() and replace kstrtoul() by kstrtobool()
> > in gpio_trig_inverted_store().
> >
> > While here, check the desired brightness against maximum defined for
> > a certain LED.
>
> One change per patch, please.
>
> Because this one will not end well.
>
> > @@ -60,10 +60,10 @@ static ssize_t gpio_trig_brightness_store(struct device *dev,
> > unsigned desired_brightness;
> > int ret;
> >
> > - ret = sscanf(buf, "%u", &desired_brightness);
> > - if (ret < 1 || desired_brightness > 255) {
> > + ret = kstrtouint(buf, 10, &desired_brightness);
> > + if (ret || desired_brightness > gpio_data->led->max_brightness) {
> > dev_err(dev, "invalid value\n");
> > - return -EINVAL;
> > + return ret ? ret : -EINVAL;
> > }
>
> We have people writing 255 into brightness, because that's what we
> used to do even for on/off LEDS. It is expected to work even for leds
> with max_brightness of 1.
>
> So... we want to saturate here, not return -EINVAL. (And we will
> eventually want to switch on/off leds to max_brightness = 1...)
Agree. Thank you for your review!
>
> > @@ -86,16 +86,13 @@ static ssize_t gpio_trig_inverted_store(struct device *dev,
> > {
> > struct led_classdev *led = led_trigger_get_led(dev);
> > struct gpio_trig_data *gpio_data = led_trigger_get_drvdata(dev);
> > - unsigned long inverted;
> > + bool inverted;
> > int ret;
> >
> > - ret = kstrtoul(buf, 10, &inverted);
> > - if (ret < 0)
> > + ret = kstrtobool(buf, &inverted);
> > + if (ret)
> > return ret;
> >
> > - if (inverted > 1)
> > - return -EINVAL;
> > -
> > gpio_data->inverted = inverted;
> >
> > /* After inverting, we need to update the LED. */
>
> So, this accepted 0/1. Now it also accepts true false and many other pairs.
>
> Which... might be ok. But probably should be separated.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-09-02 10:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 15:08 [PATCH v2 1/2] leds: trigger: gpio: GPIO 0 is valid Andy Shevchenko
2019-08-30 15:08 ` [PATCH v2 2/2] leds: trigger: gpio: Convert to use kstrtox() Andy Shevchenko
2019-09-01 10:23 ` Pavel Machek
2019-09-01 11:36 ` Jacek Anaszewski
2019-09-01 11:41 ` Jacek Anaszewski
2019-09-02 10:08 ` Andy Shevchenko [this message]
2019-08-30 21:11 ` [PATCH v2 1/2] leds: trigger: gpio: GPIO 0 is valid Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902100802.GY2680@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).