From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7DEC3A5A5 for ; Thu, 5 Sep 2019 12:06:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D0AC22CF6 for ; Thu, 5 Sep 2019 12:06:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387967AbfIEMGh (ORCPT ); Thu, 5 Sep 2019 08:06:37 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:43357 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732487AbfIEMGh (ORCPT ); Thu, 5 Sep 2019 08:06:37 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1i5qWy-00005L-6N; Thu, 05 Sep 2019 14:06:28 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1i5qWw-0004PO-P9; Thu, 05 Sep 2019 14:06:26 +0200 Date: Thu, 5 Sep 2019 14:06:26 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Dan Carpenter Cc: Jacek Anaszewski , Pavel Machek , Dan Murphy , linux-leds@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] led: triggers: Fix NULL dereference in led_trigger_set() error handling Message-ID: <20190905120626.hyegecmy6hf5lvhj@pengutronix.de> References: <20190905095728.GA26005@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190905095728.GA26005@mwanda> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-leds@vger.kernel.org Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Hello, On Thu, Sep 05, 2019 at 12:57:28PM +0300, Dan Carpenter wrote: > The problem is we set "led_cdev->trigger = NULL;" and then dereference > it when we call write_lock_irqsave(): > > write_lock_irqsave(&led_cdev->trigger->leddev_list_lock, flags); > ^^^^^^^^^^^^^^^^^ > > Fixes: 2282e125a406 ("leds: triggers: let struct led_trigger::activate() return an error code") > Signed-off-by: Dan Carpenter Obviously right. Thanks for catching. Reviewed-by: Uwe Kleine-König Did you find this at runtime or by using some static checker? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |