Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Dan Murphy <dmurphy@ti.com>,
	linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] leds: lm3692x: Probing and flag fixes
Date: Thu, 19 Sep 2019 11:54:15 +0200
Message-ID: <20190919095415.GA29939@amd> (raw)
In-Reply-To: <cover.1568772964.git.agx@sigxcpu.org>


[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

On Tue 2019-09-17 19:19:53, Guido Günther wrote:
> The driver currently returns success on init although probing fails and
> register setup uses flag values from other registers which is confusing
> when reading the driver. This series cleans this up.

1,3,4,5: Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

      parent reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18  2:19 Guido Günther
2019-09-18  2:19 ` [PATCH 1/5] leds: lm3692x: Print error value on dev_err Guido Günther
2019-09-18 18:23   ` Dan Murphy
2019-09-18  2:19 ` [PATCH 2/5] leds: lm3692x: Don't overwrite return value in error path Guido Günther
2019-09-18 18:33   ` Dan Murphy
2019-09-19 10:57   ` Pavel Machek
2019-09-18  2:19 ` [PATCH 3/5] leds: lm3692x: Handle failure to probe the regulator Guido Günther
2019-09-18 18:41   ` Dan Murphy
2019-09-18  2:19 ` [PATCH 4/5] leds: lm3692x: Use flags from LM3692X_BOOST_CTRL Guido Günther
2019-09-18 18:46   ` Dan Murphy
2019-09-18  2:19 ` [PATCH 5/5] leds: lm3692x: Use flags from LM3692X_BRT_CTRL Guido Günther
2019-09-18 18:48   ` Dan Murphy
2019-09-19  9:54 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190919095415.GA29939@amd \
    --to=pavel@ucw.cz \
    --cc=agx@sigxcpu.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org
	public-inbox-index linux-leds

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git