From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64759C3A5A2 for ; Sun, 22 Sep 2019 19:29:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C40E2054F for ; Sun, 22 Sep 2019 19:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569180577; bh=34W1jjTazjZpi9L33eWvheVRmOMYkavJ5q66RdOX93w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BXZm2W86tuYF9zZirUxaoEotw+Z3sPmW+o++0K6XtaOmhN2b82n/72NM26t64taTy WW2/qsL6wdTYjPfJ/ca6GcVSjjNqVJgZ2cYTfvh3bThUZMnV/zPErBLEjgC6v5f2j7 xDmDzSqxvJQhi4ZoV9iaQnpT5lEZTZ8NXzNqd9/o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728812AbfIVT3c (ORCPT ); Sun, 22 Sep 2019 15:29:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:46722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392505AbfIVStl (ORCPT ); Sun, 22 Sep 2019 14:49:41 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E6D41214AF; Sun, 22 Sep 2019 18:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569178180; bh=34W1jjTazjZpi9L33eWvheVRmOMYkavJ5q66RdOX93w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=snCLennm8vJ1uE6iUY06QQdEoXO8RggwHF7Lt1kgDSWlPo8sVXCuMWuU6YrNfx8BR MepUSXcmWqMge3CJ2eULwV7QpX4+NAvhy+FOe6WJnd7BZcmFxAtNDpWBDt5CL77TsS SgUTS9Qr/Hc04Wu3ZKo4bq1/JbBymuafeLo1+Nck= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nick Stoughton , Pavel Machek , Jacek Anaszewski , Sasha Levin , linux-leds@vger.kernel.org Subject: [PATCH AUTOSEL 5.2 011/185] leds: leds-lp5562 allow firmware files up to the maximum length Date: Sun, 22 Sep 2019 14:46:29 -0400 Message-Id: <20190922184924.32534-11-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190922184924.32534-1-sashal@kernel.org> References: <20190922184924.32534-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org From: Nick Stoughton [ Upstream commit ed2abfebb041473092b41527903f93390d38afa7 ] Firmware files are in ASCII, using 2 hex characters per byte. The maximum length of a firmware string is therefore 16 (commands) * 2 (bytes per command) * 2 (characters per byte) = 64 Fixes: ff45262a85db ("leds: add new LP5562 LED driver") Signed-off-by: Nick Stoughton Acked-by: Pavel Machek Signed-off-by: Jacek Anaszewski Signed-off-by: Sasha Levin --- drivers/leds/leds-lp5562.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-lp5562.c b/drivers/leds/leds-lp5562.c index 37632fc637414..edb57c42e8b1d 100644 --- a/drivers/leds/leds-lp5562.c +++ b/drivers/leds/leds-lp5562.c @@ -260,7 +260,11 @@ static void lp5562_firmware_loaded(struct lp55xx_chip *chip) { const struct firmware *fw = chip->fw; - if (fw->size > LP5562_PROGRAM_LENGTH) { + /* + * the firmware is encoded in ascii hex character, with 2 chars + * per byte + */ + if (fw->size > (LP5562_PROGRAM_LENGTH * 2)) { dev_err(&chip->cl->dev, "firmware data size overflow: %zu\n", fw->size); return; -- 2.20.1