From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=cRhg=XZ=vger.kernel.org=linux-leds-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.7 required=3.0 tests=DATE_IN_PAST_12_24,
	DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B7092C32792
	for <linux-leds@archiver.kernel.org>; Mon, 30 Sep 2019 14:08:09 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 868D9218DE
	for <linux-leds@archiver.kernel.org>; Mon, 30 Sep 2019 14:08:09 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1569852489;
	bh=iB5HY4mzec1bCNPQvr/iW+JNFvft643i72ybFWPuOiM=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=pKHONk4vbKvedhlj83BCwRaHnsqNntwKYL/eNU0dgZvauhsQz2aSQAK6iD9CmYPkD
	 MHwJTfREskNiAgDCHOGMbOTA64tgylczjiD0vDvKLPjT3DAMNp8etafvHZEfA9jH9b
	 v+GUIfrjWerrT86giw+A250QBxuNll9jvubQOxwE=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731589AbfI3OIJ (ORCPT <rfc822;linux-leds@archiver.kernel.org>);
        Mon, 30 Sep 2019 10:08:09 -0400
Received: from mail.kernel.org ([198.145.29.99]:44172 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1731375AbfI3OII (ORCPT <rfc822;linux-leds@vger.kernel.org>);
        Mon, 30 Sep 2019 10:08:08 -0400
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 45AC5216F4;
        Mon, 30 Sep 2019 14:08:07 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1569852487;
        bh=iB5HY4mzec1bCNPQvr/iW+JNFvft643i72ybFWPuOiM=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=MyqBZnMqw2JaHM+BSB+I+PeUcM4Xxuxu+PaH5+5msQysfjOkhv/u52Wf+z57Veh9E
         i6iu1h39IDWzD7c3KQC23e3GWDK43Y74v1I6jtEMuYjezaQWDtUtcNiM9CtOkRsEAI
         cM/taDpctoraBRARDAzag2bYqjCa7e9dIsT87nDU=
Date:   Sun, 29 Sep 2019 16:46:54 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Akinobu Mita <akinobu.mita@gmail.com>
Cc:     linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH v3 1/1] leds: remove PAGE_SIZE limit of
 /sys/class/leds/<led>/trigger
Message-ID: <20190929144654.GB2011467@kroah.com>
References: <1569766729-8433-1-git-send-email-akinobu.mita@gmail.com>
 <1569766729-8433-2-git-send-email-akinobu.mita@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1569766729-8433-2-git-send-email-akinobu.mita@gmail.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-leds-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-leds.vger.kernel.org>
X-Mailing-List: linux-leds@vger.kernel.org

On Sun, Sep 29, 2019 at 11:18:49PM +0900, Akinobu Mita wrote:
> Reading /sys/class/leds/<led>/trigger returns all available LED triggers.
> However, the size of this file is limited to PAGE_SIZE because of the
> limitation for sysfs attribute.
> 
> Enabling LED CPU trigger on systems with thousands of CPUs easily hits
> PAGE_SIZE limit, and makes it impossible to see all available LED triggers
> and which trigger is currently activated.
> 
> We work around it here by converting /sys/class/leds/<led>/trigger to
> binary attribute, which is not limited by length. This is _not_ good
> design, do not copy it.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>