From: Pavel Machek <pavel@denx.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Guru Das Srinagesh <gurus@codeaurora.org>,
linux-leds@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-kernel@vger.kernel.org,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>
Subject: Re: [PATCH 1/2] leds: Add flag to keep trigger always
Date: Mon, 30 Sep 2019 19:22:39 +0200 [thread overview]
Message-ID: <20190930172239.GA26107@amd> (raw)
In-Reply-To: <20190930133902.GA2249614@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]
On Mon 2019-09-30 15:39:02, Greg KH wrote:
> On Sat, Aug 10, 2019 at 09:13:22AM +0200, Pavel Machek wrote:
> > On Fri 2019-08-09 17:52:46, Guru Das Srinagesh wrote:
> > > From: Subbaraman Narayanamurthy <subbaram@codeaurora.org>
> > >
> > > Commit 0013b23d66a2768f5babbb0ea9f03ab067a990d8 ("leds: disable triggers
> > > on brightness set") removes the trigger on an LED class device when
> > > brightness is set to 0. However, there are some LED class devices which
> > > need the trigger not to be removed. In a use case like camera flash,
> > > camera flash driver passes in a trigger device to LED class driver. If
> > > the trigger is removed when the brightness is set to 0, this will affect
> > > the clients using those triggers. Hence add a flag to always keep the
> > > trigger even when brightness is set to 0.
> >
> > No.
> >
> > Yes, it would affect those clients. Don't do it, then. It is
> > root-only operation.
>
> I don't understand. The original commit broke userspace operations.
> Shouldn't it be reverted, or fixed this way in order to have userspace
> work properly again?
So, what it is exactly that is not working? :-). Yes, root can
disconnect LED from v4l2 interface; he can also connect it
back. Documentation says that happens.
Yes, root can do stupid things.
Commit 0013b23d66a2768f5babbb0ea9f03ab067a990d8 is from 2008. I'd
prefer we did not apply it in 2008, but...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-09-30 20:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-10 0:52 [PATCH 1/2] leds: Add flag to keep trigger always Guru Das Srinagesh
2019-08-10 0:52 ` [PATCH 2/2] leds: triggers: Don't remove trigger if LED_KEEP_TRIGGER flag is set Guru Das Srinagesh
2019-08-10 7:13 ` [PATCH 1/2] leds: Add flag to keep trigger always Pavel Machek
2019-09-30 13:39 ` Greg KH
2019-09-30 17:22 ` Pavel Machek [this message]
2019-09-30 17:27 ` Greg KH
2019-10-04 20:09 ` Guru Das Srinagesh
2019-10-08 7:47 ` Pavel Machek
2019-10-10 0:52 ` Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930172239.GA26107@amd \
--to=pavel@denx.de \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=gurus@codeaurora.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=subbaram@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).