From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=twXh=X3=vger.kernel.org=linux-leds-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,
	SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id AD2A7C352AA
	for <linux-leds@archiver.kernel.org>; Wed,  2 Oct 2019 15:28:31 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 8083321A4C
	for <linux-leds@archiver.kernel.org>; Wed,  2 Oct 2019 15:28:31 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1570030111;
	bh=Zs1w0+pZkf/2vTha8BF442mvOaUjsDyypVvSv2pDJ2U=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From;
	b=plfOpS5srau6Xi/N/elxEWvIbrQcVFVPY36Z7TfCG6Wud2YXBTZzsFN5Zs/hKnlBt
	 c7hLCWcptEEkniMYxy784EAsOQQ5DAj9K8J5+InbPn2lNl7XvmPpsoR7XQ4fD3F/R4
	 PShgcNaUBw2GxdOqu9ficPGkpo/zjMLKClEwUFSU=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728794AbfJBP2b (ORCPT <rfc822;linux-leds@archiver.kernel.org>);
        Wed, 2 Oct 2019 11:28:31 -0400
Received: from mail.kernel.org ([198.145.29.99]:37796 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726710AbfJBP2a (ORCPT <rfc822;linux-leds@vger.kernel.org>);
        Wed, 2 Oct 2019 11:28:30 -0400
Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id C241321920;
        Wed,  2 Oct 2019 15:28:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1570030110;
        bh=Zs1w0+pZkf/2vTha8BF442mvOaUjsDyypVvSv2pDJ2U=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=F/p4sK5ZUzn67M2+LwpcjfCoC9VcD0J1DdQ6wSTgOZ4XOUk1QotC/5IiIBhJebuXp
         xAmoCf0KxRJ0Nx2af47mhqNggLMVNFK1hbeqvxYd5PXTOrckmX7Qu7Go21yntUVqDR
         uhGU1sAYHiTqlsp04pZCBBwriCa8+D8Wu6enCrJw=
Date:   Wed, 2 Oct 2019 17:28:28 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Akinobu Mita <akinobu.mita@gmail.com>
Cc:     linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>
Subject: Re: [PATCH -next 1/2] leds: add /sys/devices/virtual/led-trigger/
Message-ID: <20191002152828.GC1748000@kroah.com>
References: <1570029181-11102-1-git-send-email-akinobu.mita@gmail.com>
 <1570029181-11102-2-git-send-email-akinobu.mita@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1570029181-11102-2-git-send-email-akinobu.mita@gmail.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-leds-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-leds.vger.kernel.org>
X-Mailing-List: linux-leds@vger.kernel.org

On Thu, Oct 03, 2019 at 12:13:00AM +0900, Akinobu Mita wrote:
> Reading /sys/class/leds/<led>/trigger returns all available LED triggers.
> However, this violates the "one value per file" rule of sysfs.
> 
> This makes led_triggers "real" devices and provides an
> /sys/devices/virtual/led-trigger/ directory that contains a sub-directoriy
> for each LED trigger device. The name of the sub-directory matches the LED
> trigger name.
> 
> We can find all available LED triggers by listing this directory contents.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
>  .../ABI/testing/sysfs-devices-virtual-led-trigger  |  8 +++
>  drivers/leds/led-triggers.c                        | 57 ++++++++++++++++++++++
>  include/linux/leds.h                               |  3 ++
>  3 files changed, 68 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-devices-virtual-led-trigger
> 
> diff --git a/Documentation/ABI/testing/sysfs-devices-virtual-led-trigger b/Documentation/ABI/testing/sysfs-devices-virtual-led-trigger
> new file mode 100644
> index 0000000..b8eb8f3
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-devices-virtual-led-trigger
> @@ -0,0 +1,8 @@
> +What:		/sys/devices/virtual/leds-trigger/
> +Date:		September 2019
> +KernelVersion:	5.5
> +Contact:	linux-leds@vger.kernel.org
> +Description:
> +		This directory contains a sub-directoriy for each LED trigger

"directoriy"?

> +		device. The name of the sub-directory matches the LED trigger
> +		name.

You are just creating directories here, and doing nothing with them,
why?  That seems kind of pointless.

thanks,

greg k-h