From: Rob Herring <robh@kernel.org>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, sre@kernel.org,
mark.rutland@arm.com, lee.jones@linaro.org,
daniel.thompson@linaro.org, dmurphy@ti.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, tomi.valkeinen@ti.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH v10 5/6] dt-bindings: backlight: Add led-backlight binding
Date: Wed, 9 Oct 2019 14:35:23 -0500 [thread overview]
Message-ID: <20191009193523.GA7094@bogus> (raw)
In-Reply-To: <20191009085127.22843-6-jjhiblot@ti.com>
On Wed, Oct 09, 2019 at 10:51:26AM +0200, Jean-Jacques Hiblot wrote:
> Add DT binding for led-backlight.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>
> ---
>
> .../leds/backlight/led-backlight.yaml | 55 +++++++++++++++++++
> 1 file changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/led-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/led-backlight.yaml
> new file mode 100644
> index 000000000000..47ae3d6b4f31
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/led-backlight.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/led-backlight.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LED-based Backlight Device Tree Bindings
> +
> +maintainers:
> + - Jean-Jacques Hiblot <jjhiblot@ti.com>
> +
> +description: |
> + This binding is used to describe a basic backlight device made of LEDs.
> + It can also be used to describe a backlight device controlled by the
> + output of a LED driver.
> +
> +properties:
> + compatible:
> + const: led-backlight
> +
> + leds:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: List of LEDs constitutive of the backlight.
> +
> + default-brightness:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Default brightness level on boot.
It's not clear that this is an index when 'brightness-levels' is present
and absolute level when not. I wonder if we've been consistent on that?
> + minimum: 0
Implied by being a uint32.
> +
> + brightness-levels:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description: Array of distinct brightness levels. The levels must be in
> + the range accepted by the underlying LED devices. This is used to
> + translate a backlight brightness level into a LED brightness level. If
> + it is not provided, the identity mapping is used.
> +
> +required:
> + - compatible
> + - backlight-leds
leds?
Add 'additionalProperties: false' here.
> +
> +examples:
> + - |
> + backlight {
Please also define $nodename is 'backlight'.
> + compatible = "led-backlight";
> + backlight-leds = <&led1>;
leds?
> + brightness-levels = <0 4 8 16 32 64 128 255>;
> + default-brightness = <6>; /*6th level => brightness of the LEDs is 128*/
> + };
> + - |
> + backlight {
> + compatible = "led-backlight";
> + backlight-leds = <&led1>, <&led2>;
> + default-brightness = <255>;
> + };
> +...
> --
> 2.17.1
>
next prev parent reply other threads:[~2019-10-09 19:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 8:51 [PATCH v10 0/6] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 1/6] leds: populate the device's of_node Jean-Jacques Hiblot
2019-10-09 10:52 ` Tomi Valkeinen
2019-10-09 8:51 ` [PATCH v10 2/6] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 3/6] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 4/6] dts-bindings: leds: Document the naming requirement for LED properties Jean-Jacques Hiblot
2019-10-09 19:26 ` Rob Herring
2019-10-10 10:31 ` Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 5/6] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-10-09 19:35 ` Rob Herring [this message]
2019-11-21 18:22 ` Tony Lindgren
2019-10-09 8:51 ` [PATCH v10 6/6] backlight: add led-backlight driver Jean-Jacques Hiblot
2019-11-21 18:13 ` Tony Lindgren
2020-01-07 10:28 ` Lee Jones
2020-01-07 13:45 ` Pavel Machek
2020-01-07 14:33 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009193523.GA7094@bogus \
--to=robh@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jjhiblot@ti.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).