From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2190C47E49 for ; Tue, 5 Nov 2019 20:57:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66E3421D7F for ; Tue, 5 Nov 2019 20:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572987441; bh=EnA5xZWNuusgfSEDFFPNayeFPVfAM0WtLBN1DOG7mkQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=CyrQL3XvoJdNil0uEdQQrdh2YKWe2nsLtCbYR/QnHBwaQEe0+FuougZTEWjwD5RAZ BWgUz4mVVZvoEukSU0QCbTyKvGh38fa+pDSqaKndjd8F/roXs6HuFgvNVEZ2KEisE3 ltj+VDWhHmdgdmtbT8o+UPVs2Ej76u39sYxeOT9g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729784AbfKEU5V (ORCPT ); Tue, 5 Nov 2019 15:57:21 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:35109 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729632AbfKEU5U (ORCPT ); Tue, 5 Nov 2019 15:57:20 -0500 Received: by mail-oi1-f195.google.com with SMTP id n16so18903672oig.2; Tue, 05 Nov 2019 12:57:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YH8No3YE+SfIIhr1pRJYlkmraO4srBIJPhAWx/BUo7o=; b=LtJCMP9BEuJo7AoGc9whEW4mnbuPZPsc+twyDY6qbUHYR6y48eKt9sSOr024qIZMpC +vBPT3LwkjdhPd8/zomVZvQJYCTFUTe3Na+3wWdneNNiuZy0hk4pTjTYjw8Z4aojRiGN 1dMAu7b2yoLyaCXjMxGJOtwYumKQVUkkSp9CNNB2m8j1qDWIk6gM9k6V83Q+U3nx5pEq 0XkkGLCXoN6OSU63kzVaLamiCLKMlunMLgpmHv3PJG1W0p26OWQfJDGc0Wc05EBv5HTK V9kabL72vZ/VYqQXAKuMVkp51jG3O1tN28DXCyTqLfAm7ZxD43kfT3cEbOoVglm+SV56 AISA== X-Gm-Message-State: APjAAAV1sf4kuI/iLEkWfM8e5uV/g4ZlAASe7p8y/PImIdU9nCZ+pf3Z uWfjp2gcTFKOqN1PnI6mJQ== X-Google-Smtp-Source: APXvYqz4PTn4LH3MKQJeJhit6JeqNJpYt06BezFqeq80P3WV6oQcYKUwj76O8XCo+mV0pvazH22q3A== X-Received: by 2002:aca:ecd0:: with SMTP id k199mr873786oih.166.1572987439487; Tue, 05 Nov 2019 12:57:19 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id o18sm6597103otj.38.2019.11.05.12.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Nov 2019 12:57:18 -0800 (PST) Date: Tue, 5 Nov 2019 14:57:18 -0600 From: Rob Herring To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Jacek Anaszewski , Pavel Machek , Dan Murphy , Mark Rutland , Lee Jones , Liam Girdwood , Mark Brown , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Alessandro Zummo , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [RFC PATCH v3 04/15] dt-bindings: leds: ROHM BD71282 PMIC LED driver Message-ID: <20191105205718.GC629@bogus> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Fri, Nov 01, 2019 at 01:32:33PM +0200, Matti Vaittinen wrote: > Document ROHM BD71828 PMIC LED driver device tree bindings. > > Signed-off-by: Matti Vaittinen > --- > > Changes from v2 - new patch > > .../bindings/leds/rohm,leds-bd71828.yaml | 46 +++++++++++++++++++ > 1 file changed, 46 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml > > diff --git a/Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml b/Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml > new file mode 100644 > index 000000000000..d8aeac9911ef > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/rohm,leds-bd71828.yaml > @@ -0,0 +1,46 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/rohm,leds-bd71828.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ROHM BD71828 Power Management Integrated Circuit LED driver > + > +maintainers: > + - Jacek Anaszewski > + - Pavel Machek > + - Dan Murphy > + - Rob Herring > + - Mark Rutland > + > +description: | > + This module is part of the ROHM BD71828 MFD device. For more details > + see Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml. > + > + The LED controller is represented as a sub-node of the PMIC node on the device > + tree. > + > + The device has two LED outputs referred as GRNLED and AMBLED in data-sheet. > + > +properties: > + compatible: > + const: rohm,bd71828-led > + > +patternProperties: > + "^led-[1-2]$": > + type: object > + description: > + Properties for a single LED. Nodes must be named as led-1 and led-2. > + properties: > + #$ref: "common.yaml#" > + function: > + description: > + Purpose of LED as defined in dt-bindings/leds/common.h > + $ref: "/schemas/types.yaml#/definitions/string" > + color: > + description: > + LED colour as defined in dt-bindings/leds/common.h > + $ref: "/schemas/types.yaml#/definitions/uint32" You can assume that we will have a common schema for these. So the only thing needed is whether you use the properties ("true" is enough for that), any additional constraints (not likely here), and whether required or not. > + > +required: > + - compatible > -- > 2.21.0 > > > -- > Matti Vaittinen, Linux device drivers > ROHM Semiconductors, Finland SWDC > Kiviharjunlenkki 1E > 90220 OULU > FINLAND > > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ > Thanks to Simon Glass for the translation =]