From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83327C43603 for ; Mon, 9 Dec 2019 12:34:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4D17E20726 for ; Mon, 9 Dec 2019 12:34:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727398AbfLIMe2 (ORCPT ); Mon, 9 Dec 2019 07:34:28 -0500 Received: from mga11.intel.com ([192.55.52.93]:29248 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727074AbfLIMe1 (ORCPT ); Mon, 9 Dec 2019 07:34:27 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Dec 2019 04:34:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,294,1571727600"; d="scan'208";a="202818237" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga007.jf.intel.com with ESMTP; 09 Dec 2019 04:34:26 -0800 Received: from andy by smile with local (Exim 4.93-RC5) (envelope-from ) id 1ieIF8-00058Q-40; Mon, 09 Dec 2019 14:34:26 +0200 Date: Mon, 9 Dec 2019 14:34:26 +0200 From: Andy Shevchenko To: Sakari Ailus Cc: linux-leds@vger.kernel.org Subject: Re: [PATCH 1/1] leds-as3645a: Drop fwnode reference on ignored node Message-ID: <20191209123426.GF32742@smile.fi.intel.com> References: <20191204075642.22070-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191204075642.22070-1-sakari.ailus@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Wed, Dec 04, 2019 at 09:56:42AM +0200, Sakari Ailus wrote: > If a node is ignored, do not get a reference to it. Fix the bug by moving > fwnode_handle_get() where a reference to an fwnode is saved for clarity. > FWIW, Reviewed-by: Andy Shevchenko > Reported-by: Andy Shevchenko > Signed-off-by: Sakari Ailus > --- > drivers/leds/leds-as3645a.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c > index b7e0ae1af8fa5..e8922fa033796 100644 > --- a/drivers/leds/leds-as3645a.c > +++ b/drivers/leds/leds-as3645a.c > @@ -493,16 +493,17 @@ static int as3645a_parse_node(struct as3645a *flash, > switch (id) { > case AS_LED_FLASH: > flash->flash_node = child; > + fwnode_handle_get(child); > break; > case AS_LED_INDICATOR: > flash->indicator_node = child; > + fwnode_handle_get(child); > break; > default: > dev_warn(&flash->client->dev, > "unknown LED %u encountered, ignoring\n", id); > break; > } > - fwnode_handle_get(child); > } > > if (!flash->flash_node) { > -- > 2.20.1 > -- With Best Regards, Andy Shevchenko