From: Sven Van Asbroeck <thesven73@gmail.com>
To: Lee Jones <lee.jones@linaro.org>, Pavel Machek <pavel@ucw.cz>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Grigoryev Denis <grigoryev@fastwel.ru>,
Axel Lin <axel.lin@ingics.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: [PATCH v6 0/2] tps6105x add devicetree and leds support
Date: Mon, 16 Dec 2019 09:32:57 -0500 [thread overview]
Message-ID: <20191216143259.24587-1-TheSven73@gmail.com> (raw)
v5 -> v6:
Dan Murphy's suggestions:
- s/mfd/MFD/
- s/led/LED/
- Added copyright message
- fixed regmap_update_bits alignment
- added a comment to clarify that fwnode / devicetree support is
optional, and device_get_next_child_node() returning NULL is
supported
Lee Jones's suggestions:
- removed 'Tree:' line from commit message
- changed over to relative paths
v4 -> v5:
Added Jacek Anaszewski's Acked-by tag on both patches.
Added Rob Herring's Reviewed-by tag on devicetree patch.
Lee Jones:
- tweaked commit message s/led/LED/
- use relative paths in Devicetree binding docs, line up ':'s
v3 -> v4:
Removed tps6105 mfd patch - it was accepted (Mark Brown).
Use the new LED registration API - suggested by Jacek Anaszewski.
Updated led dt bindings to document function, color usage.
v2 -> v3:
Removed tps6105x regulator patch - it was accepted (Mark Brown).
Removed devicetree/platdata bindings for tps6105x led naming.
I can test only with a 4.19 vendor kernel, which does not have the
latest led naming infrastructure (function/color). Drop devicetree/
fwnode/pdata led naming in favour of hard-coding to "tps6105x::torch",
so the patch can be tested by me, yet remains acceptable to upstream.
v1 -> v2:
Select chip operational mode by looking at subnode name, _not_ its
compatible property. Suggested by Mark Brown.
I needed led operation for this mfd chip, so I added a very simple
driver for this.
My platform (arm imx6q) is devicetree-based, so I added optional
devicetree support for this chip and its sub-drivers.
Sven Van Asbroeck (2):
leds: tps6105x: add driver for MFD chip LED mode
dt-bindings: mfd: update TI tps6105x chip bindings
.../devicetree/bindings/mfd/tps6105x.txt | 47 +++++++++-
drivers/leds/Kconfig | 10 +++
drivers/leds/Makefile | 1 +
drivers/leds/leds-tps6105x.c | 89 +++++++++++++++++++
4 files changed, 146 insertions(+), 1 deletion(-)
create mode 100644 drivers/leds/leds-tps6105x.c
--
2.17.1
next reply other threads:[~2019-12-16 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 14:32 Sven Van Asbroeck [this message]
2019-12-16 14:32 ` [PATCH v6 1/2] leds: tps6105x: add driver for MFD chip LED mode Sven Van Asbroeck
2019-12-21 19:04 ` Pavel Machek
2019-12-16 14:32 ` [PATCH v6 2/2] dt-bindings: mfd: update TI tps6105x chip bindings Sven Van Asbroeck
2019-12-16 16:38 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216143259.24587-1-TheSven73@gmail.com \
--to=thesven73@gmail.com \
--cc=axel.lin@ingics.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=grigoryev@fastwel.ru \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).