From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, linux-serial@vger.kernel.org
Subject: Re: [PATCH v4 1/3] tty: rename tty_kopen() and add new function tty_kopen_shared()
Date: Tue, 17 Dec 2019 19:27:54 +0100 [thread overview]
Message-ID: <20191217182754.rji5p3npzc2z4gv3@pengutronix.de> (raw)
In-Reply-To: <c83b364b-3494-cf3d-0429-61ec3b502be0@gmail.com>
Hello Jacek,
On Tue, Dec 17, 2019 at 07:08:47PM +0100, Jacek Anaszewski wrote:
> I wanted to test the set but unfortunately this
> patch does not apply. See below for the apparent reason.
>
> > [...]
> > -struct tty_struct *tty_kopen(dev_t device)
> > +static struct tty_struct *tty_kopen(dev_t device, int shared)
> > {
> > struct tty_struct *tty;
> > struct tty_driver *driver;
>
> In mainline, even in v5.5-rc2 we have here NULL assignment:
>
> struct tty_driver *driver = NULL;
Yeah, if you don't want to wait for Greg's tree to appear in next, this
is the patch you're missing:
https://lkml.org/lkml/2019/12/17/101
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-12-17 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 16:58 [PATCH v4 0/3] tty/leds: implement a trigger for ttys Uwe Kleine-König
2019-12-17 16:58 ` [PATCH v4 1/3] tty: rename tty_kopen() and add new function tty_kopen_shared() Uwe Kleine-König
2019-12-17 18:08 ` Jacek Anaszewski
2019-12-17 18:20 ` Greg Kroah-Hartman
2019-12-17 18:27 ` Uwe Kleine-König [this message]
2019-12-17 20:19 ` Jacek Anaszewski
2019-12-17 20:23 ` Greg Kroah-Hartman
2019-12-17 16:58 ` [PATCH v4 2/3] tty: new helper function tty_get_icount() Uwe Kleine-König
2019-12-17 16:58 ` [PATCH v4 3/3] leds: trigger: implement a tty trigger Uwe Kleine-König
2019-12-17 17:22 ` [PATCH v4 0/3] tty/leds: implement a trigger for ttys Greg Kroah-Hartman
2019-12-21 18:36 ` Pavel Machek
2019-12-23 9:58 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217182754.rji5p3npzc2z4gv3@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).