Re: [PATCH v7 02/12] dt-bindings: mfd: Document ROHM BD71828 bindings

From: Lee Jones <lee.jones@linaro.org>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc: "dmurphy@ti.com" <dmurphy@ti.com>,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
	"linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
	"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"jacek.anaszewski@gmail.com" <jacek.anaszewski@gmail.com>,
	"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
	"a.zummo@towertech.it" <a.zummo@towertech.it>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"sboyd@kernel.org" <sboyd@kernel.org>,
	"pavel@ucw.cz" <pavel@ucw.cz>,
	"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH v7 02/12] dt-bindings: mfd: Document ROHM BD71828 bindings
Date: Fri, 20 Dec 2019 10:55:05 +0000	[thread overview]
Message-ID: <20191220105505.GS18955@dell> (raw)
In-Reply-To: <e734a11ed158814119256a3fac253a8574c90837.camel@fi.rohmeurope.com>

On Fri, 20 Dec 2019, Vaittinen, Matti wrote:

> 
> On Thu, 2019-12-19 at 14:36 +0000, Lee Jones wrote:
> > On Thu, 19 Dec 2019, Vaittinen, Matti wrote:
> > 
> > > Hello Mark, Lee, Rob
> > > 
> > > I just noticed we have a dependency here. This binding is referring
> > > to
> > > regulator binding - which was applied by Mark and is thus missing
> > > from
> > > the series. What's the best way forward?
> > > 
> > > On Thu, 2019-12-19 at 11:46 +0200, Matti Vaittinen wrote:
> > > > ROHM BD71828 Power management IC integrates 7 buck converters, 7
> > > > LDOs,
> > > > a real-time clock (RTC), 3 GPO/regulator control pins, HALL input
> > > > and a 32.768 kHz clock gate.
> > > > 
> > > > Document the dt bindings drivers are using.
> > > > 
> > > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com
> > > > >
> > > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > > ---
> > > > 
> > > > No changes since v6
> > > 
> > > //snip
> > > 
> > > > +  regulators:
> > > > +    $ref: ../regulator/rohm,bd71828-regulator.yaml
> > > 
> > > This file is missing from the series and is applied to Mark's tree.
> > 
> > Shouldn't matter.  I guess they're all heading for he same release.
> > 
> Ok. Thanks for clarification. I was asking this because Rob asked me to
> reorder the patches a few versions ago so that the dt_binding_check
> Make target would not be broken between commits. He asked me to submit
> the regulator and LED bindings first and MFD (which refers to those)
> only after them. Thus I was wondering if the final merge order of MFD
> and regulator trees is such that it can result the breakage Rob hoped
> to avoid. But I am more than glad if the series can go in like this :)

It's not something that concerns me personally.  I only care about
*build* breakages.  Rob might be more upset about it however.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog