From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F12C9C2D0C3 for ; Sat, 21 Dec 2019 18:52:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAF6F20665 for ; Sat, 21 Dec 2019 18:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726319AbfLUSwu (ORCPT ); Sat, 21 Dec 2019 13:52:50 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:40514 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726107AbfLUSwu (ORCPT ); Sat, 21 Dec 2019 13:52:50 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id BA7C01C24DF; Sat, 21 Dec 2019 19:52:48 +0100 (CET) Date: Sat, 21 Dec 2019 19:52:48 +0100 From: Pavel Machek To: Linus Walleij Cc: Jacek Anaszewski , Dan Murphy , linux-leds@vger.kernel.org, Kim Kyuwon Subject: Re: [PATCH] leds: bd2802: Convert to use GPIO descriptors Message-ID: <20191221185248.GE32732@amd> References: <20191203095908.52926-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EXKGNeO8l0xGFBjy" Content-Disposition: inline In-Reply-To: <20191203095908.52926-1-linus.walleij@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --EXKGNeO8l0xGFBjy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2019-12-03 10:59:08, Linus Walleij wrote: > The Rohm BD2802 have no in-kernel users so we can drop the > GPIO number from the platform data and require users to > provide the GPIO line using machine descriptors. >=20 > As the descriptors come with inherent polarity inversion > semantics, we invert the calls to set the GPIO line such > that 0 means "unasserted" and 1 means "asserted". >=20 > Put a note in the driver that machine descriptor tables > will need to specify that the line is active low. >=20 > Cc: Kim Kyuwon > Signed-off-by: Linus Walleij Umm. What should I do here? Apply to next and see if it breaks something? Was this tested somehow? Best regards, Pavel =09 --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --EXKGNeO8l0xGFBjy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl3+af8ACgkQMOfwapXb+vIbaACfRbb6rjYojhs1H4oU2RDywaqq RKoAnRRpp75o71EvU2asc5CubOVg44k4 =0h7q -----END PGP SIGNATURE----- --EXKGNeO8l0xGFBjy--