Hi!

> Overvoltage protection and brightness mode are currently hardcoded
> as disabled in the driver. Make these configurable via DT.

What exactly is overvoltage protection good for? Should we default to
29V if we have no other information?

> Signed-off-by: Guido Günther <agx@sigxcpu.org>

> +	ret = device_property_read_u32(&led->client->dev,
> +				       "ti,overvoltage-volts", &ovp);
> +	if (!ret) {
> +		switch (ovp) {
> +		case 0:
> +			break;
> +		case 22:
> +			led->boost_ctrl |= LM3692X_OVP_21V;
> +			break;

Should be case 21.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html