From: Pavel Machek <pavel@ucw.cz>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] leds: lm3692x: Make sure we don't exceed the maximum led current
Date: Thu, 26 Dec 2019 11:13:36 +0100 [thread overview]
Message-ID: <20191226101336.GD4033@amd> (raw)
In-Reply-To: <96dad031f3a9ff5bbc311d0ec8768b348b996bcf.1577271823.git.agx@sigxcpu.org>
[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]
On Wed 2019-12-25 12:07:19, Guido Günther wrote:
1;2802;0c> The current is given by the formular from page 12 of
> https://www.ti.com/lit/ds/symlink/lm36922.pdf. We use this to limit the
> led's max_brightness using the led-max-microamp DT property.
>
> The formular for the lm36923 is identical according to the data
sheet.
formula?
> static int lm3692x_probe_dt(struct lm3692x_led *led)
> {
> struct fwnode_handle *child = NULL;
> struct led_init_data init_data = {};
> - u32 ovp;
> + u32 ovp, max_cur;
> bool exp_mode;
> int ret;
>
> @@ -397,6 +416,10 @@ static int lm3692x_probe_dt(struct lm3692x_led *led)
> return ret;
> }
>
> + fwnode_property_read_u32(child, "led-max-microamp", &max_cur);
> + led->led_dev.max_brightness = ret ? LED_FULL :
> + lm3692x_max_brightness(led, max_cur);
> +
Umm. Should ret come from this fwnode_property_read_u32()?
With that fixed,
Acked-by: Pavel Machek <pavel@ucw.cz>
(Feel free to wait for Rob before resending the series, and I guess
you can merge it with the next one).
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-12-26 10:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 11:07 [PATCH v2 0/6] leds: lm3692x: Allow to set ovp and brigthness mode Guido Günther
2019-12-25 11:07 ` [PATCH v2 1/6] dt: bindings: lm3692x: Add ti,ovp-microvolt property Guido Günther
2019-12-26 10:06 ` Pavel Machek
2019-12-27 12:17 ` Guido Günther
2019-12-25 11:07 ` [PATCH v2 2/6] leds: lm3692x: Allow to configure over voltage protection Guido Günther
2019-12-26 10:07 ` Pavel Machek
2019-12-25 11:07 ` [PATCH v2 3/6] dt: bindings: lm3692x: Add ti,brightness-mapping-exponential property Guido Günther
2019-12-25 11:07 ` [PATCH v2 4/6] leds: lm3692x: Allow to configure brigthness mode Guido Günther
2019-12-25 11:07 ` [PATCH v2 5/6] dt: bindings: lm3692x: Add led-max-microamp property Guido Günther
2019-12-26 10:08 ` Pavel Machek
2019-12-25 11:07 ` [PATCH v2 6/6] leds: lm3692x: Make sure we don't exceed the maximum led current Guido Günther
2019-12-26 10:13 ` Pavel Machek [this message]
2019-12-27 12:59 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191226101336.GD4033@amd \
--to=pavel@ucw.cz \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).