From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C9D2C2D0DA for ; Thu, 26 Dec 2019 10:30:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01BC92075E for ; Thu, 26 Dec 2019 10:29:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726075AbfLZK37 (ORCPT ); Thu, 26 Dec 2019 05:29:59 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:44554 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726055AbfLZK37 (ORCPT ); Thu, 26 Dec 2019 05:29:59 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 964A61C2103; Thu, 26 Dec 2019 11:29:57 +0100 (CET) Date: Thu, 26 Dec 2019 11:29:56 +0100 From: Pavel Machek To: Guido =?iso-8859-1?Q?G=FCnther?= Cc: Jacek Anaszewski , Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] leds: lm3692x: Disable chip on brightness 0 Message-ID: <20191226102956.GH4033@amd> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="it/zdz3K1bH9Y8/E" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --it/zdz3K1bH9Y8/E Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2019-12-25 12:16:39, Guido G=FCnther wrote: > Otherwise there's a noticeable glow even with brightness 0. Also > turning off the regulator can save additional power. Ok, this will make set brightness slower, but I guess it makes sense. Can you try to toggling brightness quickly from userspace, maybe even =66rom two threads, to ensure nothing really goes wrong there? Hmm. And if this is independend of the other series, tell me and I can apply v2. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --it/zdz3K1bH9Y8/E Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl4Ei6QACgkQMOfwapXb+vKRlACgjsmUKw5HTV41mZpVjYyCe4a+ jxAAn0TJv2kocImeeHf4JNzTV0lAj5vi =iO66 -----END PGP SIGNATURE----- --it/zdz3K1bH9Y8/E--