From: "Guido Günther" <agx@sigxcpu.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] leds: lm3692x: Disable chip on brightness 0
Date: Fri, 27 Dec 2019 13:56:26 +0100 [thread overview]
Message-ID: <20191227125626.GA26038@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <20191226102956.GH4033@amd>
Hi Pavel,
On Thu, Dec 26, 2019 at 11:29:56AM +0100, Pavel Machek wrote:
> On Wed 2019-12-25 12:16:39, Guido Günther wrote:
> > Otherwise there's a noticeable glow even with brightness 0. Also
> > turning off the regulator can save additional power.
>
> Ok, this will make set brightness slower, but I guess it makes sense.
>
> Can you try to toggling brightness quickly from userspace, maybe even
> from two threads, to ensure nothing really goes wrong there?
I ran brightness setting in a tight loop from 0 to max from two threads
100 times without issues.
>
> Hmm. And if this is independend of the other series, tell me and I can
> apply v2.
There's minor merge conflict so to make sure this does not get dependent
on the order i've folded this to the end of the
"leds: lm3692x: Allow to set ovp and brigthness mode"
series with your Acked-by's folded in. I'll wait a couple of days and
then send out a v3.
Cheers and thanks for having a look,
-- Guido
>
> Best regards,
> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2019-12-27 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 11:16 [PATCH 0/3] leds: lm3692x: Disable chip on brightness 0 Guido Günther
2019-12-25 11:16 ` [PATCH 1/3] leds: lm3692x: Move lm3692x_init and rename to lm3692x_leds_enable Guido Günther
2019-12-26 10:15 ` Pavel Machek
2019-12-25 11:16 ` [PATCH 2/3] leds: lm3692x: Split out lm3692x_leds_disable Guido Günther
2019-12-26 10:16 ` Pavel Machek
2019-12-25 11:16 ` [PATCH 3/3] leds: lm3692x: Disable chip on brightness 0 Guido Günther
2019-12-26 10:29 ` Pavel Machek
2019-12-27 12:56 ` Guido Günther [this message]
2019-12-26 10:14 ` [PATCH 0/3] " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191227125626.GA26038@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).