From: Simon Guinot <simon.guinot@sequanux.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org,
Vincent Donnefort <vdonnefort@gmail.com>
Subject: Re: [PATCH 2/2] leds: ns2: Convert to GPIO descriptors
Date: Tue, 7 Jan 2020 15:55:08 +0100 [thread overview]
Message-ID: <20200107145508.GA21102@kw.sim.vm.gnt> (raw)
In-Reply-To: <20200107141742.GA13954@duo.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Tue, Jan 07, 2020 at 03:17:42PM +0100, Pavel Machek wrote:
> Hi!
>
> > This converts the NS2 LED driver to use GPIO descriptors.
> > We take care to request the GPIOs "as is" which is what
> > the current driver goes to lengths to achieve, then we use
> > GPIOs throughout.
> >
> > As the nodes for each LED does not have any corresponding
> > device, we need to use the DT-specific accessors to get these
> > GPIO descriptors from the device tree.
>
> Ok. But what is motivation for doing this? Was this tested?
>
> Does anyone still use leds-ns2?
Hi,
Yes the leds-ns2 driver is used by The LaCie Network Space v2 family of
NAS and by the Seagate NAS 2 and 4-Bay. The latter is a bit old but not
obsolete. AFAIK all this NASes are supported by Debian.
I'll do the testing this week-end.
Simon
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-07 15:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 14:10 [PATCH 1/2] leds: ns2: Absorb platform data Linus Walleij
2020-01-07 14:10 ` [PATCH 2/2] leds: ns2: Convert to GPIO descriptors Linus Walleij
2020-01-07 14:17 ` Pavel Machek
2020-01-07 14:55 ` Simon Guinot [this message]
2020-01-07 21:12 ` Linus Walleij
2020-01-12 13:56 ` Simon Guinot
2020-02-26 13:30 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107145508.GA21102@kw.sim.vm.gnt \
--to=simon.guinot@sequanux.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).