From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 572F9C33CB3 for ; Fri, 17 Jan 2020 10:28:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2577F20842 for ; Fri, 17 Jan 2020 10:28:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tCMW61Fm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726587AbgAQK2p (ORCPT ); Fri, 17 Jan 2020 05:28:45 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:37207 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726371AbgAQK2p (ORCPT ); Fri, 17 Jan 2020 05:28:45 -0500 Received: by mail-wr1-f65.google.com with SMTP id w15so22205326wru.4 for ; Fri, 17 Jan 2020 02:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=HM8k535bB4Zqi0GfEwiVkH65Q1Hx/nKHz6GT9gtlJK8=; b=tCMW61FmdGXdIuVJCSqzhkwiTfYOiBEraLBbZak05Sydy8wmfz0edGWG5HrRIsuJLG XThNvBabfIFmMR1OhH9jUJ9a0fcI5ii9eWn6NkqJZRwdHAJ3+zYROsw4UuYiIJWdnmXD G1w6KXRhriSabWcDZiOnERZQQRRcebgZ6MUzd4euNcxa2i81NB6ftT3PyJ4H6EF6F7EM 3hMaklaXVx2Vjb8mhoE8oTea1xrJL7bAOUnYD2pTShBwNKq1q6OyTiOo+X/982WAKlqe mB689VYvqjIUZpOwAG3fGg2ss4aqyI3S4KO6NDGqNK3PqDbctNcqrdhGIDHnjitMPoTb bbkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HM8k535bB4Zqi0GfEwiVkH65Q1Hx/nKHz6GT9gtlJK8=; b=ft2cI1Fp90EIQaCDAYEsdJigj0vC4QEXdSQmPgFc/slTbPN9Jco2QKQeWMeRPMF0md BRvQzRQCDhABiqwj+muawTGi1uGbdsZzdW1CKl9OO4oplUW3zUg6mp308VM6X1t7zwHp ODQUFXvnoq8rh/5KFqV5OQm6HXahXCADIcjEubMu4+IOPcb5ACMeW1VVEjbSlDn06EEs GSHxgkCv3WZ5uBP7ILSkiOI0mQS+nCRp2eCKOCBqX4QJSLIOchN6yP9D6RQ7c7m7Qczv 9D8S9ZvdIk2h4tdN/9VMqCS3f4G1Oew9BEl5bjFs7BaJkessIYQsPOAgijyJ33LysgZG wgMA== X-Gm-Message-State: APjAAAWcu9wLP3bC5K5bGgLRTuOh6oEZZaqLzDCem1BP/wvq0OtOIXsF VHQ8rrfc/MiyS7n/uuPcdKdtqiW/mOw= X-Google-Smtp-Source: APXvYqwDd77HblT/audWRHo3+KrxugU1EyNDv8T/9d4EkPqm8mp6uRaVfV41S/do8ghBL1uvF/IRNQ== X-Received: by 2002:a5d:67c7:: with SMTP id n7mr2234575wrw.319.1579256923293; Fri, 17 Jan 2020 02:28:43 -0800 (PST) Received: from dell ([2.27.35.221]) by smtp.gmail.com with ESMTPSA id l7sm33815710wrq.61.2020.01.17.02.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 02:28:42 -0800 (PST) Date: Fri, 17 Jan 2020 10:28:54 +0000 From: Lee Jones To: Matti Vaittinen Cc: mazziesaccount@gmail.com, Jacek Anaszewski , Pavel Machek , Dan Murphy , Rob Herring , Mark Rutland , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Liam Girdwood , Mark Brown , Alessandro Zummo , Alexandre Belloni , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org Subject: Re: [PATCH v10 08/13] regulator: bd718x7: Split driver to common and bd718x7 specific parts Message-ID: <20200117102854.GF15507@dell> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Archived-At: List-Archive: List-Post: On Fri, 17 Jan 2020, Matti Vaittinen wrote: > Few ROHM PMICs allow setting the voltage states for different system states > like RUN, IDLE, SUSPEND and LPSR. States are then changed via SoC specific > mechanisms. bd718x7 driver implemented device-tree parsing functions for > these state specific voltages. The parsing functions can be re-used by > other ROHM chip drivers like bd71828. Split the generic functions from > bd718x7-regulator.c to rohm-regulator.c and export them for other modules > to use. > > Signed-off-by: Matti Vaittinen > Acked-by: Mark Brown > --- > no changes since v9 > > drivers/regulator/Kconfig | 4 + > drivers/regulator/Makefile | 1 + > drivers/regulator/bd718x7-regulator.c | 183 ++++++++------------------ > drivers/regulator/rohm-regulator.c | 95 +++++++++++++ > include/linux/mfd/rohm-generic.h | 66 ++++++++++ > 5 files changed, 221 insertions(+), 128 deletions(-) > create mode 100644 drivers/regulator/rohm-regulator.c [...] > diff --git a/include/linux/mfd/rohm-generic.h b/include/linux/mfd/rohm-generic.h > index ff3dd7578fd3..6cc5a0819959 100644 > --- a/include/linux/mfd/rohm-generic.h > +++ b/include/linux/mfd/rohm-generic.h > @@ -4,6 +4,9 @@ > #ifndef __LINUX_MFD_ROHM_H__ > #define __LINUX_MFD_ROHM_H__ > > +#include > +#include > + > enum rohm_chip_type { > ROHM_CHIP_TYPE_BD71837 = 0, > ROHM_CHIP_TYPE_BD71847, > @@ -17,4 +20,67 @@ struct rohm_regmap_dev { > struct regmap *regmap; > }; > > +enum { > + ROHM_DVS_LEVEL_UNKNOWN, > + ROHM_DVS_LEVEL_RUN, > + ROHM_DVS_LEVEL_IDLE, > + ROHM_DVS_LEVEL_SUSPEND, > + ROHM_DVS_LEVEL_LPSR, > +#define ROHM_DVS_LEVEL_MAX ROHM_DVS_LEVEL_LPSR Haven't seen this before. Is it legit? What about: ROHM_DVS_LEVEL_MAX = ROHM_DVS_LEVEL_LPSR -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog