From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>, Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, Linux LED Subsystem <linux-leds@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Sascha Hauer <kernel@pengutronix.de>, "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org> Subject: Re: [PATCH v6 1/4] lib: new helper kstrtodev_t() Date: Thu, 20 Feb 2020 08:49:01 +0100 Message-ID: <20200220074901.ohcrisjgd26555ya@pengutronix.de> (raw) In-Reply-To: <CAHp75VcStj5sE3f0uK2deOWC=ojfx-z1fbrh6Lu6jAor9F9PgA@mail.gmail.com> On Wed, Feb 19, 2020 at 09:50:54PM +0200, Andy Shevchenko wrote: > On Thu, Feb 13, 2020 at 11:27 AM Uwe Kleine-König <uwe@kleine-koenig.org> wrote: > > > > This function is in the same spirit as the other kstrto* functions and > > uses the same calling convention. It expects the input string to be in > > the format %u:%u and implements stricter parsing than sscanf as it > > returns an error on trailing data (other than the usual \n). > > Can we first split the kstrotox* (and simple_strto*) to the separate > header first? I don't feel strong here what is right. But I hesitate to create another pre-condition for this patch set. > On top of that, why kstrtodev_t is so important? How many users are > already in the kernel to get an advantage out of it? Does it need to be important? It matches the other kstrto* functions and so it seemed more natural to me to put it near the other functions. I'm not aware of other potential users and surprised you seem to suggest this as a requirement. > What to do with all other possible variants ("%d:%d", "%dx%d" and its > %u variant, etc)? I don't see how %d:%d is relevant, major and minor cannot be negative can they? I never saw 'x' as separator between major and minor. I considered shortly parsing %u, but given that (I think) this is an internal representation only I chose to not make it more visible than it already is. > Why simple_strto*() can't be used? I didn't really consider it, but looking in more detail I don't like it much. Without having tried it I think simple_strtoull accepts "1000000000000000000000000000000000000000000" returning some arbitrary value without an error indication. And given that I was asked for strict parsing (i.e. not accepting 2:4:something) I'd say using simple_strto* is a step backwards. Also simple_strtoul() has "This function is obsolete. Please use kstrtoul instead." in its docstring which seems to apply to the other simple_strto*() functions, too. > > #include <linux/export.h> > > #include <linux/types.h> > > #include <linux/uaccess.h> > > > +#include <linux/kdev_t.h> > > Perhaps preserve order? Can do. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply index Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-13 9:15 [PATCH v6 0/4] leds: trigger: implement a tty trigger Uwe Kleine-König 2020-02-13 9:15 ` [PATCH v6 1/4] lib: new helper kstrtodev_t() Uwe Kleine-König 2020-02-19 19:50 ` Andy Shevchenko 2020-02-20 7:49 ` Uwe Kleine-König [this message] 2020-02-20 10:22 ` Andy Shevchenko 2020-02-20 10:57 ` Uwe Kleine-König 2020-02-20 11:46 ` Andy Shevchenko 2020-02-20 11:57 ` Andy Shevchenko 2020-02-20 14:01 ` Uwe Kleine-König 2020-02-21 8:42 ` Andy Shevchenko 2020-02-21 10:53 ` Uwe Kleine-König 2020-04-25 7:07 ` Pavel Machek 2020-02-13 9:15 ` [PATCH v6 2/4] tty: rename tty_kopen() and add new function tty_kopen_shared() Uwe Kleine-König 2020-02-19 13:21 ` Johan Hovold 2020-02-19 16:37 ` Uwe Kleine-König 2020-02-19 17:17 ` Johan Hovold 2020-02-20 11:04 ` Uwe Kleine-König 2020-02-25 8:55 ` Johan Hovold 2020-02-25 9:05 ` Uwe Kleine-König 2020-02-13 9:15 ` [PATCH v6 3/4] tty: new helper function tty_get_icount() Uwe Kleine-König 2020-02-13 9:16 ` [PATCH v6 4/4] leds: trigger: implement a tty trigger Uwe Kleine-König 2020-02-19 10:52 ` Johan Hovold 2020-02-19 11:03 ` Uwe Kleine-König 2020-02-19 11:19 ` Johan Hovold 2020-02-19 12:48 ` Johan Hovold 2020-02-19 10:40 ` [PATCH v6 0/4] " Greg Kroah-Hartman 2020-02-26 14:02 ` Pavel Machek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200220074901.ohcrisjgd26555ya@pengutronix.de \ --to=u.kleine-koenig@pengutronix.de \ --cc=andy.shevchenko@gmail.com \ --cc=dmurphy@ti.com \ --cc=gregkh@linuxfoundation.org \ --cc=jacek.anaszewski@gmail.com \ --cc=jslaby@suse.com \ --cc=kernel@pengutronix.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=pavel@ucw.cz \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-LEDs Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \ linux-leds@vger.kernel.org public-inbox-index linux-leds Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds AGPL code for this site: git clone https://public-inbox.org/public-inbox.git