From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE8F6C3F2D2 for ; Fri, 28 Feb 2020 09:39:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 835B024672 for ; Fri, 28 Feb 2020 09:39:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726631AbgB1Jj0 (ORCPT ); Fri, 28 Feb 2020 04:39:26 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:33602 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726005AbgB1JjZ (ORCPT ); Fri, 28 Feb 2020 04:39:25 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id BB4AA1C030F; Fri, 28 Feb 2020 10:39:23 +0100 (CET) Date: Fri, 28 Feb 2020 10:39:23 +0100 From: Pavel Machek To: Jacek Anaszewski Cc: Dan Murphy , Greg KH , Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v17 00/17] Multi Color LED Framework Message-ID: <20200228093923.GC27860@amd> References: <20200127150032.31350-1-dmurphy@ti.com> <42d9687b-b488-22cf-0e9a-ff635b2094e3@ti.com> <20200225101940.GB16252@amd> <20200226125903.GA2800@duo.ucw.cz> <20f6bdd5-e899-aead-8c35-1c3a3d09145f@gmail.com> <20200227105808.GA27003@duo.ucw.cz> <20200227124329.GA994747@kroah.com> <4c273c06-5024-b2d4-c656-b165015090be@ti.com> <96a31ff6-5ecf-05a7-d61f-2804f2488d1b@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E/DnYTRukya0zdZ1" Content-Disposition: inline In-Reply-To: <96a31ff6-5ecf-05a7-d61f-2804f2488d1b@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --E/DnYTRukya0zdZ1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >> Writing 3 or 4 or 5 numbers all at once in a single sysfs file to > >> represent a single output should be fine. > >> thanks, >=20 > Thank you for making this clear. >=20 > Effectively, the way to go as I see it now is just moving from > colors directory to channel_intensity and channel_names files. Yes. > Besides that, since the issue of backwards compatibility with > LED class still remains, we need to apply the already worked out > formula for mapping brightness to color iout values. >=20 > This implies that color values written to channel_intensity file > will be written unchanged to the hw only when global brightness > is equal to max_brightness. This is because they will be multiplied > by brightness / max_brightness ratio. >=20 > Do you agree, Pavel? Yes. That seems like possible solution. Pavel --=20 DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany --E/DnYTRukya0zdZ1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl5Y38sACgkQMOfwapXb+vJHkwCgofCcau0VBti/twGZP1zeOZV+ 9X4An1TLM76oJaHBTOHcUTt3MF1J5VG5 =EYF3 -----END PGP SIGNATURE----- --E/DnYTRukya0zdZ1--