From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FACCC54FCE for ; Tue, 24 Mar 2020 09:42:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FC052080C for ; Tue, 24 Mar 2020 09:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727124AbgCXJm1 (ORCPT ); Tue, 24 Mar 2020 05:42:27 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:44776 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727230AbgCXJm1 (ORCPT ); Tue, 24 Mar 2020 05:42:27 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 574CA1C0343; Tue, 24 Mar 2020 10:42:25 +0100 (CET) Date: Tue, 24 Mar 2020 10:42:22 +0100 From: Pavel Machek To: Nicolas Belin Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com, dmurphy@ti.com, devicetree@vger.kernel.org, baylibre-upstreaming@groups.io Subject: Re: [PATCH v3 3/3] drivers: leds: add support for apa102c leds Message-ID: <20200324094222.GA15096@amd> References: <1583502010-16210-1-git-send-email-nbelin@baylibre.com> <1583502010-16210-4-git-send-email-nbelin@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IS0zKkzwUGydFO0o" Content-Disposition: inline In-Reply-To: <1583502010-16210-4-git-send-email-nbelin@baylibre.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --IS0zKkzwUGydFO0o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri 2020-03-06 14:40:10, Nicolas Belin wrote: > Initilial commit in order to support the apa102c RGB leds. The Initial > RGB and global brightness management is done by creating 4 leds > from the Led Framework per apa102c led. >=20 > + > + /* setting a color_id value for each of the 4 components of the > + * apa102c RGB led. The first component is the global brightness > + * of the led and thus has no color. The order of the colors > + * after the global brightness is then blue, green and red > + * in that order. It corresponds to the order in which the > + * values are sent using spi > + */ > + rgb_led->component[0].color_id =3D -1; //no color Please follow codingstyle on comment style and avoid // comments. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --IS0zKkzwUGydFO0o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl551f4ACgkQMOfwapXb+vKNAACdHyKBsVW3v6cli5ZVCgheH7ky D3kAnA22fu4Dv4StJjio2r7Ne6PEyWkM =IEwh -----END PGP SIGNATURE----- --IS0zKkzwUGydFO0o--