From: Dan Murphy <dmurphy@ti.com>
To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Dan Murphy <dmurphy@ti.com>
Subject: [PATCH v25 13/16] leds: lp5521: Add multicolor framework multicolor brightness support
Date: Mon, 4 May 2020 16:13:41 -0500 [thread overview]
Message-ID: <20200504211344.13221-14-dmurphy@ti.com> (raw)
In-Reply-To: <20200504211344.13221-1-dmurphy@ti.com>
Add the multicolor brightness call back to support the multicolor
framework. This function allows setting the brightness across
grouped LED channels in a single call.
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
drivers/leds/Kconfig | 1 +
drivers/leds/leds-lp5521.c | 20 ++++++++++++++++++++
2 files changed, 21 insertions(+)
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 8b28f73c810c..bdf8fc2652fb 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -398,6 +398,7 @@ config LEDS_LP55XX_COMMON
config LEDS_LP5521
tristate "LED Support for N.S. LP5521 LED driver chip"
depends on LEDS_CLASS && I2C
+ depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR
select LEDS_LP55XX_COMMON
help
If you say yes here you get support for the National Semiconductor
diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
index 6ff81d6be789..ef8c3bfa8f3c 100644
--- a/drivers/leds/leds-lp5521.c
+++ b/drivers/leds/leds-lp5521.c
@@ -349,6 +349,25 @@ static int lp5521_run_selftest(struct lp55xx_chip *chip, char *buf)
return 0;
}
+static int lp5521_multicolor_brightness(struct lp55xx_led *led)
+{
+ struct lp55xx_chip *chip = led->chip;
+ int ret;
+ int i;
+
+ mutex_lock(&chip->lock);
+ for (i = 0; i < led->mc_cdev.num_colors; i++) {
+ ret = lp55xx_write(chip,
+ LP5521_REG_LED_PWM_BASE +
+ led->mc_cdev.subled_info[i].channel,
+ led->mc_cdev.subled_info[i].brightness);
+ if (ret)
+ break;
+ }
+ mutex_unlock(&chip->lock);
+ return ret;
+}
+
static int lp5521_led_brightness(struct lp55xx_led *led)
{
struct lp55xx_chip *chip = led->chip;
@@ -490,6 +509,7 @@ static struct lp55xx_device_config lp5521_cfg = {
.max_channel = LP5521_MAX_LEDS,
.post_init_device = lp5521_post_init_device,
.brightness_fn = lp5521_led_brightness,
+ .multicolor_brightness_fn = lp5521_multicolor_brightness,
.set_led_current = lp5521_set_led_current,
.firmware_cb = lp5521_firmware_loaded,
.run_engine = lp5521_run_engine,
--
2.25.1
next prev parent reply other threads:[~2020-05-04 21:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 21:13 [PATCH v25 00/16] Multicolor Framework v25 Dan Murphy
2020-05-04 21:13 ` [PATCH v25 01/16] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-05-26 12:00 ` Dan Murphy
2020-05-26 12:29 ` (dt review needed) " Pavel Machek
2020-05-26 16:30 ` Rob Herring
2020-05-04 21:13 ` [PATCH v25 02/16] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-05-04 21:13 ` [PATCH v25 03/16] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-05-04 21:13 ` [PATCH v25 04/16] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-05-04 21:13 ` [PATCH v25 05/16] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2020-05-04 21:13 ` [PATCH v25 06/16] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2020-05-04 21:13 ` [PATCH v25 07/16] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-05-04 21:13 ` [PATCH v25 08/16] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-05-04 21:13 ` [PATCH v25 09/16] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-05-04 21:13 ` [PATCH v25 10/16] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-05-04 21:13 ` [PATCH v25 11/16] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-05-04 21:13 ` [PATCH v25 12/16] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-05-04 21:13 ` Dan Murphy [this message]
2020-05-04 21:13 ` [PATCH v25 14/16] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2020-05-04 21:13 ` [PATCH v25 15/16] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
2020-05-04 21:13 ` [PATCH v25 16/16] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy
2020-05-12 18:54 ` [PATCH v25 00/16] Multicolor Framework v25 Dan Murphy
2020-05-25 21:58 ` Pavel Machek
2020-05-26 16:46 Dan Murphy
2020-05-26 16:46 ` [PATCH v25 13/16] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504211344.13221-14-dmurphy@ti.com \
--to=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).