From: Dan Murphy <dmurphy@ti.com>
To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>
Cc: <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Dan Murphy <dmurphy@ti.com>
Subject: [PATCH v25 15/16] leds: lp5523: Fix checkpatch issues in the code
Date: Mon, 4 May 2020 16:13:43 -0500 [thread overview]
Message-ID: <20200504211344.13221-16-dmurphy@ti.com> (raw)
In-Reply-To: <20200504211344.13221-1-dmurphy@ti.com>
Fix checkpatch errors and warnings for the LP5523.c device
driver.
Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: Dan Murphy <dmurphy@ti.com>
---
drivers/leds/leds-lp5523.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index 9776dc72a764..f55d97258d5e 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -23,13 +23,13 @@
#define LP5523_PROGRAM_LENGTH 32 /* bytes */
/* Memory is used like this:
- 0x00 engine 1 program
- 0x10 engine 2 program
- 0x20 engine 3 program
- 0x30 engine 1 muxing info
- 0x40 engine 2 muxing info
- 0x50 engine 3 muxing info
-*/
+ * 0x00 engine 1 program
+ * 0x10 engine 2 program
+ * 0x20 engine 3 program
+ * 0x30 engine 1 muxing info
+ * 0x40 engine 2 muxing info
+ * 0x50 engine 3 muxing info
+ */
#define LP5523_MAX_LEDS 9
/* Registers */
@@ -326,7 +326,7 @@ static int lp5523_update_program_memory(struct lp55xx_chip *chip,
const u8 *data, size_t size)
{
u8 pattern[LP5523_PROGRAM_LENGTH] = {0};
- unsigned cmd;
+ unsigned int cmd;
char c[3];
int nrchars;
int ret;
@@ -468,6 +468,7 @@ static int lp5523_mux_parse(const char *buf, u16 *mux, size_t len)
static void lp5523_mux_to_array(u16 led_mux, char *array)
{
int i, pos = 0;
+
for (i = 0; i < LP5523_MAX_LEDS; i++)
pos += sprintf(array + pos, "%x", LED_ACTIVE(led_mux, i));
@@ -506,7 +507,7 @@ static int lp5523_load_mux(struct lp55xx_chip *chip, u16 mux, int nr)
if (ret)
return ret;
- ret = lp55xx_write(chip, LP5523_REG_PROG_MEM , (u8)(mux >> 8));
+ ret = lp55xx_write(chip, LP5523_REG_PROG_MEM, (u8)(mux >> 8));
if (ret)
return ret;
--
2.25.1
next prev parent reply other threads:[~2020-05-04 21:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 21:13 [PATCH v25 00/16] Multicolor Framework v25 Dan Murphy
2020-05-04 21:13 ` [PATCH v25 01/16] dt: bindings: Add multicolor class dt bindings documention Dan Murphy
2020-05-26 12:00 ` Dan Murphy
2020-05-26 12:29 ` (dt review needed) " Pavel Machek
2020-05-26 16:30 ` Rob Herring
2020-05-04 21:13 ` [PATCH v25 02/16] leds: multicolor: Introduce a multicolor class definition Dan Murphy
2020-05-04 21:13 ` [PATCH v25 03/16] dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers Dan Murphy
2020-05-04 21:13 ` [PATCH v25 04/16] leds: lp50xx: Add the LP50XX family of the RGB LED driver Dan Murphy
2020-05-04 21:13 ` [PATCH v25 05/16] dt: bindings: lp55xx: Be consistent in the document with LED acronym Dan Murphy
2020-05-04 21:13 ` [PATCH v25 06/16] dt: bindings: lp55xx: Update binding for Multicolor Framework Dan Murphy
2020-05-04 21:13 ` [PATCH v25 07/16] ARM: dts: n900: Add reg property to the LP5523 channel node Dan Murphy
2020-05-04 21:13 ` [PATCH v25 08/16] ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 " Dan Murphy
2020-05-04 21:13 ` [PATCH v25 09/16] ARM: dts: ste-href: Add reg property to the LP5521 channel nodes Dan Murphy
2020-05-04 21:13 ` [PATCH v25 10/16] leds: lp55xx: Convert LED class registration to devm_* Dan Murphy
2020-05-04 21:13 ` [PATCH v25 11/16] leds: lp55xx: Add multicolor framework support to lp55xx Dan Murphy
2020-05-04 21:13 ` [PATCH v25 12/16] leds: lp5523: Update the lp5523 code to add multicolor brightness function Dan Murphy
2020-05-04 21:13 ` [PATCH v25 13/16] leds: lp5521: Add multicolor framework multicolor brightness support Dan Murphy
2020-05-04 21:13 ` [PATCH v25 14/16] leds: lp55xx: Fix checkpatch file permissions issues Dan Murphy
2020-05-04 21:13 ` Dan Murphy [this message]
2020-05-04 21:13 ` [PATCH v25 16/16] dt: bindings: Update lp55xx binding to recommended LED naming Dan Murphy
2020-05-12 18:54 ` [PATCH v25 00/16] Multicolor Framework v25 Dan Murphy
2020-05-25 21:58 ` Pavel Machek
2020-05-26 16:46 Dan Murphy
2020-05-26 16:46 ` [PATCH v25 15/16] leds: lp5523: Fix checkpatch issues in the code Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504211344.13221-16-dmurphy@ti.com \
--to=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).