From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Xing Zhang <Xing.Zhang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v1] Add support for MediaTek regulator vibrator driver
Date: Thu, 7 May 2020 23:09:54 +0200 [thread overview]
Message-ID: <20200507210954.GB19557@duo.ucw.cz> (raw)
In-Reply-To: <49089bf3-d64b-2a50-269c-623a6ea9c14c@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]
On Thu 2020-05-07 22:45:35, Jacek Anaszewski wrote:
> Hi Pavel,
>
> On 5/7/20 7:45 PM, Pavel Machek wrote:
> > Hi!
> >
> > > This patchset add regulator vibrator driver for MTK Soc. The driver
> > > controls vibrator through regulator's enable and disable.
> >
> > We'd prefer not to have vibrators in led subsystem.
> >
> > >
> > > Xing Zhang (3):
> > > dt-bindings: add regulator vibrator documentation
> > > arm64: mediatek: Add regulator vibrator support
> > > Vibrator: Add regulator vibrator driver
> > >
> > > .../bindings/leds/regulator-vibrator.txt | 39 ++
> > > arch/arm64/configs/defconfig | 1 +
> > > drivers/leds/Kconfig | 10 +
> > > drivers/leds/Makefile | 1 +
> > > drivers/leds/regulator-vibrator.c | 450 ++++++++++++++++++
> >
> > OTOH, connecting LED to regulator might make some sense. I can take the driver with
> > vibrator functionality stripped, provided it is named the usual way...
>
> We already had an attempt of solving this in more generic way [0],
> but you opposed then [1]. Just for the record.
That's something different. led-regulator.c might be
acceptable. Special code to support vibrator quirks... not so much.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2020-05-07 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200429081759.26964-1-Xing.Zhang@mediatek.com>
2020-05-07 17:45 ` [PATCH v1] Add support for MediaTek regulator vibrator driver Pavel Machek
2020-05-07 20:45 ` Jacek Anaszewski
2020-05-07 21:09 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507210954.GB19557@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=Xing.Zhang@mediatek.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).