From: Marek Behun <marek.behun@nic.cz>
To: linux-leds@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: add cznic,turris-omnia-leds binding
Date: Mon, 11 May 2020 22:01:51 +0200
Message-ID: <20200511220151.24985832@nic.cz> (raw)
In-Reply-To: <20200511194354.GA15606@bogus>
On Mon, 11 May 2020 14:43:54 -0500
Rob Herring <robh@kernel.org> wrote:
> On Thu, Apr 23, 2020 at 08:50:59AM +0200, Marek Behún wrote:
> > Add device-tree bindings documentation for Turris Omnia RGB LEDs.
> >
> > ...
> >
> > +properties:
> > + compatible:
> > + const: cznic,turris-omnia-leds
> > +
> > + reg:
> > + description: I2C slave address of the microcontroller.
> > + maxItems: 1
> > +
> > +patternProperties:
> > + "^led[0-9][0-9]?$":
>
> 'led-' is preferred. And numbering is usually hex.
>
> What's the numbering here based on? Might be better to use 'reg' (and a
> unit-address) rather than led-sources. led-sources was for cases where
> the control interface (defined by reg) could have differing regulators
> connected to the LEDs.
Jacek, Pavel, it seems that it would be better if I just rewrote the
driver into Dan's multicolor API. It would solve Rob's complaint and
could be merged once multicolor framework is...
Marek
next prev parent reply index
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 6:50 [PATCH v2 0/2] Add Turris Omnia LEDs driver Marek Behún
2020-04-23 6:50 ` [PATCH v2 1/2] dt-bindings: leds: add cznic,turris-omnia-leds binding Marek Behún
2020-05-11 19:43 ` Rob Herring
2020-05-11 20:01 ` Marek Behun [this message]
2020-04-23 6:51 ` [PATCH v2 2/2] leds: initial support for Turris Omnia LEDs Marek Behún
2020-05-11 19:54 ` Dan Murphy
2020-05-11 20:17 ` Marek Behun
2020-05-11 20:21 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200511220151.24985832@nic.cz \
--to=marek.behun@nic.cz \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-LEDs Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
linux-leds@vger.kernel.org
public-inbox-index linux-leds
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git