Hi! Thanks for reviews! > > +additionalProperties: false > > +... > > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c > > This isn't a binding file. Belongs in another patch. These constants are directly related to the binding. It makes sense to go in one patch... Best regards, Pavel > > index f1f718dbe0f8..846248a0693d 100644 > > --- a/drivers/leds/led-core.c > > +++ b/drivers/leds/led-core.c > > @@ -34,6 +34,7 @@ const char * const led_colors[LED_COLOR_ID_MAX] = { > > [LED_COLOR_ID_VIOLET] = "violet", > > [LED_COLOR_ID_YELLOW] = "yellow", > > [LED_COLOR_ID_IR] = "ir", > > + [LED_COLOR_ID_MULTI] = "multicolor", > > }; > > EXPORT_SYMBOL_GPL(led_colors); > > > > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h > > index 0ce7dfc00dcb..a463ce6a8794 100644 > > --- a/include/dt-bindings/leds/common.h > > +++ b/include/dt-bindings/leds/common.h > > @@ -30,7 +30,8 @@ > > #define LED_COLOR_ID_VIOLET 5 > > #define LED_COLOR_ID_YELLOW 6 > > #define LED_COLOR_ID_IR 7 > > -#define LED_COLOR_ID_MAX 8 > > +#define LED_COLOR_ID_MULTI 8 > > +#define LED_COLOR_ID_MAX 9 > > > > /* Standard LED functions */ > > /* Keyboard LEDs, usually it would be input4::capslock etc. */ > > -- > > 2.25.1 > > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html