From: Johan Hovold <johan@kernel.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>,
Amitoj Kaur Chawla <amitoj1606@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 0/6] leds: fix broken devres usage
Date: Mon, 1 Jun 2020 15:39:44 +0200 [thread overview]
Message-ID: <20200601133950.12420-1-johan@kernel.org> (raw)
Several MFD child drivers register their class devices directly under
the parent device (about half of the MFD LED drivers do so).
This means you cannot blindly do devres conversions so that
deregistration ends up being tied to the parent device, something which
leads to use-after-free on driver unbind when the class device is
released while still being registered (and, for example, oopses on later
parent MFD driver unbind or LED class callbacks, or resource leaks and
name clashes on child driver reload).
Included is also a clean up removing some pointless casts when
registering class devices.
All but the lm3533 one have only been compile tested.
Johan
Johan Hovold (6):
leds: 88pm860x: fix use-after-free on unbind
leds: da903x: fix use-after-free on unbind
leds: lm3533: fix use-after-free on unbind
leds: lm36274: fix use-after-free on unbind
leds: wm831x-status: fix use-after-free on unbind
leds: drop redundant struct-device pointer casts
drivers/leds/leds-88pm860x.c | 14 +++++++++++++-
drivers/leds/leds-da903x.c | 14 +++++++++++++-
drivers/leds/leds-lm3533.c | 12 +++++++++---
drivers/leds/leds-lm355x.c | 9 +++------
drivers/leds/leds-lm36274.c | 15 ++++++++++++---
drivers/leds/leds-lm3642.c | 9 +++------
drivers/leds/leds-wm831x-status.c | 14 +++++++++++++-
7 files changed, 66 insertions(+), 21 deletions(-)
--
2.26.2
next reply other threads:[~2020-06-01 13:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 13:39 Johan Hovold [this message]
2020-06-01 13:39 ` [PATCH 1/6] leds: 88pm860x: fix use-after-free on unbind Johan Hovold
2020-06-01 13:39 ` [PATCH 2/6] leds: da903x: " Johan Hovold
2020-06-01 13:39 ` [PATCH 3/6] leds: lm3533: " Johan Hovold
2020-06-01 13:39 ` [PATCH 4/6] leds: lm36274: " Johan Hovold
2020-06-01 13:39 ` [PATCH 5/6] leds: wm831x-status: " Johan Hovold
2020-06-01 13:39 ` [PATCH 6/6] leds: drop redundant struct-device pointer casts Johan Hovold
2020-06-01 13:51 ` [PATCH 0/6] leds: fix broken devres usage Andy Shevchenko
2020-06-01 14:01 ` Johan Hovold
2020-06-01 14:08 ` Andy Shevchenko
2020-06-01 14:29 ` Johan Hovold
2020-06-01 15:09 ` Andy Shevchenko
2020-06-01 15:31 ` Johan Hovold
2020-06-02 8:32 ` Andy Shevchenko
2020-06-04 13:31 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601133950.12420-1-johan@kernel.org \
--to=johan@kernel.org \
--cc=amitoj1606@gmail.com \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).