From: Pavel Machek <pavel@ucw.cz>
To: "Ondřej Jirman" <megous@megous.com>,
linux-kernel@vger.kernel.org,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Dan Murphy" <dmurphy@ti.com>,
"open list:LED SUBSYSTEM" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH RFC] leds: Add support for per-LED device triggers
Date: Sat, 4 Jul 2020 22:07:20 +0200 [thread overview]
Message-ID: <20200704200720.GA24405@amd> (raw)
In-Reply-To: <20200704121737.xiwcqzsfuzy3k3qf@core.my.home>
[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]
Hi!
> > > Add support for registering per-LED device trigger.
> > >
> > > Names of private triggers need to be globally unique, but may clash
> > > with other private triggers. This is enforced during trigger
> >
> > Globally unique name is going to be a problem, no? If you have two
> > keyboards with automatical backlight support...
>
> Only globally unique in a sense that they must not clash with non
> per-LED trigger names. So you can have two keyboards with 'self-working'
> trigger on their LED devices in sysfs.
>
> This requirement only comes from the fact that this shares the
> same sysfs configuration interface as regular non-private triggers.
Ok. That looks sane.
And if you tweak code a bit (don't compare pointers to struct led;
have struct hw_trigger_group, and compare pointers to that), you
should be able to fix the uglyness Marek mentioned without major changes.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-07-04 20:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 14:47 [PATCH RFC] leds: Add support for per-LED device triggers Ondrej Jirman
2020-07-02 14:51 ` Ondřej Jirman
2020-07-03 10:06 ` Marek Behún
2020-07-03 13:08 ` Ondřej Jirman
2020-07-08 14:55 ` Marek Behún
2020-07-04 12:59 ` Pavel Machek
2020-07-08 14:56 ` Marek Behún
2020-07-04 12:04 ` Pavel Machek
2020-07-04 12:17 ` Ondřej Jirman
2020-07-04 20:07 ` Pavel Machek [this message]
2020-07-11 10:04 ` Pavel Machek
2020-07-11 21:01 ` Ondřej Jirman
2020-07-12 7:25 ` Pavel Machek
2020-07-12 13:49 ` Ondřej Jirman
2020-07-12 19:11 ` Pavel Machek
2020-07-12 21:10 ` Marek Behun
2020-07-12 22:12 ` Ondřej Jirman
2020-07-12 22:38 ` Ondřej Jirman
2020-07-12 23:15 ` Marek Behun
2020-07-12 23:18 ` Marek Behun
2020-07-13 7:12 ` Pavel Machek
2020-07-12 23:20 ` Ondřej Jirman
2020-07-13 1:56 ` Ondřej Jirman
2020-07-15 17:07 ` Marek Behún
2020-07-15 17:55 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704200720.GA24405@amd \
--to=pavel@ucw.cz \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=megous@megous.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).