* [PATCH 0/2] leds: pca955x: Add IBM software implemenation of the PCA9552 chip @ 2020-07-09 20:12 Eddie James 2020-07-09 20:12 ` [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string Eddie James 2020-07-09 20:12 ` [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip Eddie James 0 siblings, 2 replies; 8+ messages in thread From: Eddie James @ 2020-07-09 20:12 UTC (permalink / raw) To: linux-leds Cc: linux-kernel, devicetree, robh+dt, dmurphy, pavel, jacek.anaszewski, eajames, vishwa IBM created an implementation of the PCA9552 on a PIC16F microcontroller. The I2C device addresses are different from the hardware PCA9552, so add a new compatible string and associated platform data to be able to probe this device, and document the new string. Eddie James (2): dt-bindings: leds: pca955x: Add IBM implementation compatible string leds: pca955x: Add an IBM software implementation of the PCA9552 chip Documentation/devicetree/bindings/leds/leds-pca955x.txt | 1 + drivers/leds/leds-pca955x.c | 8 ++++++++ 2 files changed, 9 insertions(+) -- 2.24.0 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string 2020-07-09 20:12 [PATCH 0/2] leds: pca955x: Add IBM software implemenation of the PCA9552 chip Eddie James @ 2020-07-09 20:12 ` Eddie James 2020-07-11 13:48 ` Pavel Machek 2020-07-09 20:12 ` [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip Eddie James 1 sibling, 1 reply; 8+ messages in thread From: Eddie James @ 2020-07-09 20:12 UTC (permalink / raw) To: linux-leds Cc: linux-kernel, devicetree, robh+dt, dmurphy, pavel, jacek.anaszewski, eajames, vishwa IBM created an implementation of the PCA9552 on a PIC16F microcontroller. Document the new compatible string for this device. Signed-off-by: Eddie James <eajames@linux.ibm.com> --- Documentation/devicetree/bindings/leds/leds-pca955x.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/leds/leds-pca955x.txt b/Documentation/devicetree/bindings/leds/leds-pca955x.txt index 7a5830f8d5ab..28edb976ee77 100644 --- a/Documentation/devicetree/bindings/leds/leds-pca955x.txt +++ b/Documentation/devicetree/bindings/leds/leds-pca955x.txt @@ -9,6 +9,7 @@ Required properties: "nxp,pca9550" "nxp,pca9551" "nxp,pca9552" + "nxp,pca9552-ibm" "nxp,pca9553" - #address-cells: must be 1 - #size-cells: must be 0 -- 2.24.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string 2020-07-09 20:12 ` [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string Eddie James @ 2020-07-11 13:48 ` Pavel Machek 2020-07-13 14:28 ` Eddie James 0 siblings, 1 reply; 8+ messages in thread From: Pavel Machek @ 2020-07-11 13:48 UTC (permalink / raw) To: Eddie James Cc: linux-leds, linux-kernel, devicetree, robh+dt, dmurphy, jacek.anaszewski, vishwa [-- Attachment #1: Type: text/plain, Size: 830 bytes --] Hi! > IBM created an implementation of the PCA9552 on a PIC16F > microcontroller. Document the new compatible string for this device. Is the implementation opensource? > Signed-off-by: Eddie James <eajames@linux.ibm.com> > +++ b/Documentation/devicetree/bindings/leds/leds-pca955x.txt > @@ -9,6 +9,7 @@ Required properties: > "nxp,pca9550" > "nxp,pca9551" > "nxp,pca9552" > + "nxp,pca9552-ibm" > "nxp,pca9553" Is it good idea to use nxp prefix for something that is software-defined and not built by nxp? Would ibm,pca9552 be better, or maybe even sw,pca9552 to indicate that is not real hardware, but software emulation? Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string 2020-07-11 13:48 ` Pavel Machek @ 2020-07-13 14:28 ` Eddie James 2020-07-20 22:25 ` Rob Herring 0 siblings, 1 reply; 8+ messages in thread From: Eddie James @ 2020-07-13 14:28 UTC (permalink / raw) To: Pavel Machek Cc: linux-leds, linux-kernel, devicetree, robh+dt, dmurphy, jacek.anaszewski, vishwa On 7/11/20 8:48 AM, Pavel Machek wrote: > Hi! > >> IBM created an implementation of the PCA9552 on a PIC16F >> microcontroller. Document the new compatible string for this device. > Is the implementation opensource? Hi, no it is not. > >> Signed-off-by: Eddie James <eajames@linux.ibm.com> >> +++ b/Documentation/devicetree/bindings/leds/leds-pca955x.txt >> @@ -9,6 +9,7 @@ Required properties: >> "nxp,pca9550" >> "nxp,pca9551" >> "nxp,pca9552" >> + "nxp,pca9552-ibm" >> "nxp,pca9553" > Is it good idea to use nxp prefix for something that is > software-defined and not built by nxp? Yea I suppose not... > > Would ibm,pca9552 be better, or maybe even sw,pca9552 to indicate that > is not real hardware, but software emulation? How about ibm,pca9552-sw? Someone suggested that just adding "sw" could be a problem if another company does the same thing but it isn't compatible. Thanks for taking a look! Eddie > > Best regards, > Pavel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string 2020-07-13 14:28 ` Eddie James @ 2020-07-20 22:25 ` Rob Herring 0 siblings, 0 replies; 8+ messages in thread From: Rob Herring @ 2020-07-20 22:25 UTC (permalink / raw) To: Eddie James Cc: Pavel Machek, linux-leds, linux-kernel, devicetree, dmurphy, jacek.anaszewski, vishwa On Mon, Jul 13, 2020 at 09:28:32AM -0500, Eddie James wrote: > > On 7/11/20 8:48 AM, Pavel Machek wrote: > > Hi! > > > > > IBM created an implementation of the PCA9552 on a PIC16F > > > microcontroller. Document the new compatible string for this device. > > Is the implementation opensource? > > > Hi, no it is not. > > > > > > > Signed-off-by: Eddie James <eajames@linux.ibm.com> > > > +++ b/Documentation/devicetree/bindings/leds/leds-pca955x.txt > > > @@ -9,6 +9,7 @@ Required properties: > > > "nxp,pca9550" > > > "nxp,pca9551" > > > "nxp,pca9552" > > > + "nxp,pca9552-ibm" > > > "nxp,pca9553" > > Is it good idea to use nxp prefix for something that is > > software-defined and not built by nxp? > > > Yea I suppose not... > > > > > Would ibm,pca9552 be better, or maybe even sw,pca9552 to indicate that > > is not real hardware, but software emulation? > > > How about ibm,pca9552-sw? Someone suggested that just adding "sw" could be a > problem if another company does the same thing but it isn't compatible. ibm,pca9552 is good. Rob ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip 2020-07-09 20:12 [PATCH 0/2] leds: pca955x: Add IBM software implemenation of the PCA9552 chip Eddie James 2020-07-09 20:12 ` [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string Eddie James @ 2020-07-09 20:12 ` Eddie James 2020-07-09 20:50 ` Andy Shevchenko 1 sibling, 1 reply; 8+ messages in thread From: Eddie James @ 2020-07-09 20:12 UTC (permalink / raw) To: linux-leds Cc: linux-kernel, devicetree, robh+dt, dmurphy, pavel, jacek.anaszewski, eajames, vishwa IBM created an implementation of the PCA9552 on a PIC16F microcontroller. The I2C device addresses are different from the hardware PCA9552, so add a new compatible string and associated platform data to be able to probe this device. Signed-off-by: Eddie James <eajames@linux.ibm.com> Reviewed-by: Vishwanatha Subbanna <vishwa@linux.vnet.ibm.com> --- drivers/leds/leds-pca955x.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/leds/leds-pca955x.c b/drivers/leds/leds-pca955x.c index 4037c504589c..bf7ead45f66b 100644 --- a/drivers/leds/leds-pca955x.c +++ b/drivers/leds/leds-pca955x.c @@ -65,6 +65,7 @@ enum pca955x_type { pca9550, pca9551, pca9552, + pca9552_ibm, pca9553, }; @@ -90,6 +91,11 @@ static struct pca955x_chipdef pca955x_chipdefs[] = { .slv_addr = /* 1100xxx */ 0x60, .slv_addr_shift = 3, }, + [pca9552_ibm] = { + .bits = 16, + .slv_addr = /* 0110xxx */ 0x30, + .slv_addr_shift = 3, + }, [pca9553] = { .bits = 4, .slv_addr = /* 110001x */ 0x62, @@ -101,6 +107,7 @@ static const struct i2c_device_id pca955x_id[] = { { "pca9550", pca9550 }, { "pca9551", pca9551 }, { "pca9552", pca9552 }, + { "pca9552-ibm", pca9552_ibm }, { "pca9553", pca9553 }, { } }; @@ -412,6 +419,7 @@ static const struct of_device_id of_pca955x_match[] = { { .compatible = "nxp,pca9550", .data = (void *)pca9550 }, { .compatible = "nxp,pca9551", .data = (void *)pca9551 }, { .compatible = "nxp,pca9552", .data = (void *)pca9552 }, + { .compatible = "nxp,pca9552-ibm", .data = (void *)pca9552_ibm }, { .compatible = "nxp,pca9553", .data = (void *)pca9553 }, {}, }; -- 2.24.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip 2020-07-09 20:12 ` [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip Eddie James @ 2020-07-09 20:50 ` Andy Shevchenko 2020-07-13 14:29 ` Eddie James 0 siblings, 1 reply; 8+ messages in thread From: Andy Shevchenko @ 2020-07-09 20:50 UTC (permalink / raw) To: Eddie James Cc: Linux LED Subsystem, Linux Kernel Mailing List, devicetree, Rob Herring, Dan Murphy, Pavel Machek, Jacek Anaszewski, vishwa On Thu, Jul 9, 2020 at 11:16 PM Eddie James <eajames@linux.ibm.com> wrote: > > IBM created an implementation of the PCA9552 on a PIC16F > microcontroller. The I2C device addresses are different from the > hardware PCA9552, so add a new compatible string and associated > platform data to be able to probe this device. This is weird. I would rather expect ibm prefix with corresponding part number. > + pca9552_ibm, > + [pca9552_ibm] = { > + { "pca9552-ibm", pca9552_ibm }, > + { .compatible = "nxp,pca9552-ibm", .data = (void *)pca9552_ibm }, -- With Best Regards, Andy Shevchenko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip 2020-07-09 20:50 ` Andy Shevchenko @ 2020-07-13 14:29 ` Eddie James 0 siblings, 0 replies; 8+ messages in thread From: Eddie James @ 2020-07-13 14:29 UTC (permalink / raw) To: Andy Shevchenko Cc: Linux LED Subsystem, Linux Kernel Mailing List, devicetree, Rob Herring, Dan Murphy, Pavel Machek, Jacek Anaszewski, vishwa On 7/9/20 3:50 PM, Andy Shevchenko wrote: > On Thu, Jul 9, 2020 at 11:16 PM Eddie James <eajames@linux.ibm.com> wrote: >> IBM created an implementation of the PCA9552 on a PIC16F >> microcontroller. The I2C device addresses are different from the >> hardware PCA9552, so add a new compatible string and associated >> platform data to be able to probe this device. > This is weird. I would rather expect ibm prefix with corresponding part number. Yep I agree now, see my note to Pavel just now. Thanks, Eddie > >> + pca9552_ibm, >> + [pca9552_ibm] = { >> + { "pca9552-ibm", pca9552_ibm }, >> + { .compatible = "nxp,pca9552-ibm", .data = (void *)pca9552_ibm }, > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-07-20 22:25 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-09 20:12 [PATCH 0/2] leds: pca955x: Add IBM software implemenation of the PCA9552 chip Eddie James 2020-07-09 20:12 ` [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string Eddie James 2020-07-11 13:48 ` Pavel Machek 2020-07-13 14:28 ` Eddie James 2020-07-20 22:25 ` Rob Herring 2020-07-09 20:12 ` [PATCH 2/2] leds: pca955x: Add an IBM software implementation of the PCA9552 chip Eddie James 2020-07-09 20:50 ` Andy Shevchenko 2020-07-13 14:29 ` Eddie James
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).