From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9A79C433F2 for ; Sun, 12 Jul 2020 23:15:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B807020720 for ; Sun, 12 Jul 2020 23:15:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nic.cz header.i=@nic.cz header.b="MYtHsD7V" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728845AbgGLXPs (ORCPT ); Sun, 12 Jul 2020 19:15:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728617AbgGLXPr (ORCPT ); Sun, 12 Jul 2020 19:15:47 -0400 X-Greylist: delayed 7544 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sun, 12 Jul 2020 16:15:47 PDT Received: from mail.nic.cz (lists.nic.cz [IPv6:2001:1488:800:400::400]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80E66C061794; Sun, 12 Jul 2020 16:15:47 -0700 (PDT) Received: from localhost (unknown [172.20.6.135]) by mail.nic.cz (Postfix) with ESMTPSA id 400AA13F657; Mon, 13 Jul 2020 01:15:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1594595745; bh=a+el10ZHHG0H2equijCDFaZPRdBBA7n9Ne/c/r1f2V4=; h=Date:From:To; b=MYtHsD7V5T6iBMB/TjB/gxbpI8qNixefeNOZWiOQe+kf1pc5xoJQ8hd3dYPqaJLPh 67uU3bbb+/4dLe+0iCelvxb3b/HPiK4VYUPHU8UC5irGTQkj8eKZo/xW8wuhKT8Qcj +rs3m0MU17c5Vll1eZDZahsfOKVbXtteKd41CyB8= Date: Mon, 13 Jul 2020 01:15:44 +0200 From: Marek Behun To: =?UTF-8?B?T25kxZllag==?= Jirman Cc: Pavel Machek , linux-kernel@vger.kernel.org, Jacek Anaszewski , Dan Murphy , "open list:LED SUBSYSTEM" Subject: Re: [PATCH RFC] leds: Add support for per-LED device triggers Message-ID: <20200713011544.0adc51f1@nic.cz> In-Reply-To: <20200712223821.742ljr4qxdrx3aqv@core.my.home> References: <20200702144712.1994685-1-megous@megous.com> <20200711100409.GA18901@amd> <20200711210111.5ysijhexgyzyr7u7@core.my.home> <20200712072554.GC4721@duo.ucw.cz> <20200712134911.r3lig4hgyqhmslth@core.my.home> <20200712191111.GA20592@amd> <20200712223821.742ljr4qxdrx3aqv@core.my.home> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon, 13 Jul 2020 00:38:21 +0200 Ond=C5=99ej Jirman wrote: > Hello, >=20 > On Sun, Jul 12, 2020 at 09:11:11PM +0200, Pavel Machek wrote: > > Hi! > > =20 >=20 > [....] >=20 > > } > > diff --git a/include/linux/leds.h b/include/linux/leds.h > > index 2451962d1ec5..cba52714558f 100644 > > --- a/include/linux/leds.h > > +++ b/include/linux/leds.h > > @@ -57,6 +57,10 @@ struct led_init_data { > > bool devname_mandatory; > > }; > > =20 > > +struct led_hw_trigger_type { > > + int dummy; > > +} > > + > > struct led_classdev { > > const char *name; > > enum led_brightness brightness; > > @@ -150,6 +154,8 @@ struct led_classdev { > > =20 > > /* Ensures consistent access to the LED Flash Class device */ > > struct mutex led_access; > > + > > + struct led_hw_trigger_type *trigger_type; > > }; > > =20 > > /** > > @@ -345,6 +351,9 @@ struct led_trigger { > > int (*activate)(struct led_classdev *led_cdev); > > void (*deactivate)(struct led_classdev *led_cdev); > > =20 > > + /* LED-private triggers have this set. */ > > + struct led_hw_trigger_type *trigger_type; > > + > > /* LEDs under control by this trigger (for simple triggers) */ > > rwlock_t leddev_list_lock; > > struct list_head led_cdevs; =20 >=20 > So after trying to use this, this seems to disallow the use of multiple HW > triggers per LED. That's fine by me, because using one HW sysfs configured > trigger per LED that use case is my proposal, but is it desireable in gen= eral? Why? If you register one LED and several triggers, all sharing the same trigger_type pointer, I think it should work. Marek