From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2332C433F7 for ; Mon, 20 Jul 2020 22:25:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C3CC22B4E for ; Mon, 20 Jul 2020 22:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595283915; bh=bwCEworh58RcUk5LnVr3vxqbKQZFoHSCyw41iKuGV1c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=DKrYySgSM7ice8vIqTXAhJn6KyW14X+ZJ3xYUW+Xb9qLLqMR1CIE9oXyyuZ0U8GCO 0Gz+p6lWy2LEhILQ2kNRmxgLIIy0bpR1RMul6PUE3KAocinhxxLc5nMriSfo0i+28R fJu0XPEVQzTMu8OG4NHhfY/Df6CgA4edLxk+ZZ4k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728294AbgGTWZJ (ORCPT ); Mon, 20 Jul 2020 18:25:09 -0400 Received: from mail-il1-f196.google.com ([209.85.166.196]:36588 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726061AbgGTWZF (ORCPT ); Mon, 20 Jul 2020 18:25:05 -0400 Received: by mail-il1-f196.google.com with SMTP id x9so14729042ila.3; Mon, 20 Jul 2020 15:25:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MZqPehWuAaKZ1kDIiDAtIDxeI9fYnQ6uKzjYm+bg3hw=; b=l74HM/QEIyMume9MYOGL+Y2z/FpKO5mNYjLxU543TVaJxNc1xBJ42YvkAIISSKnsEa BDpZUGL1ddvRTET/lKwYmmBZh9ZzLdLAnj0F1QC8Hdw0iKqeMj0kuUftRM0h1UTJEHiT T38wgfr7vRM3mFCQXPGGIwvGk3D3OptoSbNVorfCByFGrsEr5D8H1nd48LA4t1wN7//d 04EQfb9/DkkvgMwzhOAw0Vx2wfE1EqRlDEU2byM43dBDaa4XJXpCn6HCFI6KmDQfo6hJ M7t49+PCrBVsXg0zWnK8MWer9TVHLN993BEGVbNbggCjliAQ9XLYu9YtmDFKklBBxN6y 8YfQ== X-Gm-Message-State: AOAM533J6fkqwJJcHqhzt2Ny74kVvpzTFnsADYeC8zBZjY4Qfw2YDJnB ZXEe75K0vSEZmCWB+LrlpQ== X-Google-Smtp-Source: ABdhPJwB+CzpX9Dgd3C5ILBklMR8r62BD85LbwTOjFwD1kOkV+ZDYDVOCXLvY4fVyBJrJ9WY0ZIYUA== X-Received: by 2002:a92:8552:: with SMTP id f79mr25548228ilh.225.1595283904930; Mon, 20 Jul 2020 15:25:04 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id u9sm10033330iom.14.2020.07.20.15.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2020 15:25:04 -0700 (PDT) Received: (nullmailer pid 3060507 invoked by uid 1000); Mon, 20 Jul 2020 22:25:03 -0000 Date: Mon, 20 Jul 2020 16:25:03 -0600 From: Rob Herring To: Eddie James Cc: Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dmurphy@ti.com, jacek.anaszewski@gmail.com, vishwa@linux.ibm.com Subject: Re: [PATCH 1/2] dt-bindings: leds: pca955x: Add IBM implementation compatible string Message-ID: <20200720222503.GA3058862@bogus> References: <20200709201220.13736-1-eajames@linux.ibm.com> <20200709201220.13736-2-eajames@linux.ibm.com> <20200711134814.GB6407@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon, Jul 13, 2020 at 09:28:32AM -0500, Eddie James wrote: > > On 7/11/20 8:48 AM, Pavel Machek wrote: > > Hi! > > > > > IBM created an implementation of the PCA9552 on a PIC16F > > > microcontroller. Document the new compatible string for this device. > > Is the implementation opensource? > > > Hi, no it is not. > > > > > > > Signed-off-by: Eddie James > > > +++ b/Documentation/devicetree/bindings/leds/leds-pca955x.txt > > > @@ -9,6 +9,7 @@ Required properties: > > > "nxp,pca9550" > > > "nxp,pca9551" > > > "nxp,pca9552" > > > + "nxp,pca9552-ibm" > > > "nxp,pca9553" > > Is it good idea to use nxp prefix for something that is > > software-defined and not built by nxp? > > > Yea I suppose not... > > > > > Would ibm,pca9552 be better, or maybe even sw,pca9552 to indicate that > > is not real hardware, but software emulation? > > > How about ibm,pca9552-sw? Someone suggested that just adding "sw" could be a > problem if another company does the same thing but it isn't compatible. ibm,pca9552 is good. Rob