From: Pavel Machek <pavel@ucw.cz>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: netdev@vger.kernel.org, linux-leds@vger.kernel.org,
jacek.anaszewski@gmail.com, "Dan Murphy" <dmurphy@ti.com>,
"Ondřej Jirman" <megous@megous.com>,
"Russell King" <linux@armlinux.org.uk>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Andrew Lunn" <andrew@lunn.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class
Date: Sat, 25 Jul 2020 11:23:39 +0200 [thread overview]
Message-ID: <20200725092339.GB29492@amd> (raw)
In-Reply-To: <20200724164603.29148-3-marek.behun@nic.cz>
[-- Attachment #1: Type: text/plain, Size: 2334 bytes --]
Hi!
> +static const struct marvell_led_mode_info marvell_led_mode_info[] = {
> + { "link", { 0x0, -1, 0x0, -1, -1, -1, }, 0 },
> + { "link/act", { 0x1, 0x1, 0x1, 0x1, 0x1, 0x1, }, 0 },
> + { "1Gbps/100Mbps/10Mbps", { 0x2, -1, -1, -1, -1, -1, }, 0 },
is this "1Gbps-10Mbps"?
> + { "act", { 0x3, 0x3, 0x3, 0x3, 0x3, 0x3, }, 0 },
> + { "blink-act", { 0x4, 0x4, 0x4, 0x4, 0x4, 0x4, }, 0 },
> + { "tx", { 0x5, -1, 0x5, -1, 0x5, 0x5, }, 0 },
> + { "tx", { -1, -1, -1, 0x5, -1, -1, }, L3V5_TRANS },
> + { "rx", { -1, -1, -1, -1, 0x0, 0x0, }, 0 },
> + { "rx", { -1, 0x0, -1, -1, -1, -1, }, L1V0_RECV },
> + { "copper", { 0x6, -1, -1, -1, -1, -1, }, 0 },
> + { "copper", { -1, 0x0, -1, -1, -1, -1, }, L1V0_COPPER },
> + { "1Gbps", { 0x7, -1, -1, -1, -1, -1, }, 0 },
> + { "link/rx", { -1, 0x2, -1, 0x2, 0x2, 0x2, }, 0 },
> + { "100Mbps-fiber", { -1, 0x5, -1, -1, -1, -1, }, L1V5_100_FIBER },
> + { "100Mbps-10Mbps", { -1, 0x5, -1, -1, -1, -1, }, L1V5_100_10 },
> + { "1Gbps-100Mbps", { -1, 0x6, -1, -1, -1, -1, }, 0 },
> + { "1Gbps-10Mbps", { -1, -1, 0x6, 0x6, -1, -1, }, 0 },
> + { "100Mbps", { -1, 0x7, -1, -1, -1, -1, }, 0 },
> + { "10Mbps", { -1, -1, 0x7, -1, -1, -1, }, 0 },
> + { "fiber", { -1, -1, -1, 0x0, -1, -1, }, L3V0_FIBER },
> + { "fiber", { -1, -1, -1, 0x7, -1, -1, }, L3V7_FIBER },
> + { "FullDuplex", { -1, -1, -1, 0x7, -1, -1, }, L3V7_DUPLEX },
> + { "FullDuplex", { -1, -1, -1, -1, 0x6, 0x6, }, 0 },
> + { "FullDuplex/collision", { -1, -1, -1, -1, 0x7, 0x7, }, 0 },
> + { "FullDuplex/collision", { -1, -1, 0x2, -1, -1, -1, }, L2V2_DUPLEX },
> + { "ptp", { -1, -1, 0x2, -1, -1, -1, }, L2V2_PTP },
> + { "init", { -1, -1, 0x2, -1, -1, -1, }, L2V2_INIT },
> + { "los", { -1, -1, -1, 0x0, -1, -1, }, L3V0_LOS },
> + { "hi-z", { 0xa, 0xa, 0xa, 0xa, 0xa, 0xa, }, 0 },
> + { "blink", { 0xb, 0xb, 0xb, 0xb, 0xb, 0xb, }, 0 },
> +};
Certainly more documentation will be required here, what "ptp" setting
does, for example, is not very obvious to me.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-07-25 9:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 16:46 [PATCH RFC leds + net-next v3 0/2] Add support for LEDs on Marvell PHYs Marek Behún
2020-07-24 16:46 ` [PATCH RFC leds + net-next v3 1/2] net: phy: add API for LEDs controlled by PHY HW Marek Behún
2020-07-25 9:21 ` Pavel Machek
2020-07-25 9:37 ` Marek Behun
2020-07-25 16:22 ` Andrew Lunn
2020-07-24 16:46 ` [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class Marek Behún
2020-07-25 9:23 ` Pavel Machek [this message]
2020-07-25 9:34 ` Marek Behun
2020-07-25 15:03 ` Andrew Lunn
2020-07-25 17:39 ` Marek Behun
2020-07-25 17:47 ` Andrew Lunn
2020-07-25 17:23 ` Andrew Lunn
2020-07-25 18:02 ` Marek Behun
2020-07-25 18:23 ` Andrew Lunn
2020-07-25 18:48 ` Andrew Lunn
2020-07-25 20:58 ` Marek Behun
2020-08-07 9:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200725092339.GB29492@amd \
--to=pavel@ucw.cz \
--cc=andrew@lunn.ch \
--cc=dmurphy@ti.com \
--cc=gregory.clement@bootlin.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marek.behun@nic.cz \
--cc=megous@megous.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).