From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64DF5C433E4 for ; Sat, 25 Jul 2020 17:40:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 473AF206D7 for ; Sat, 25 Jul 2020 17:40:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726969AbgGYRjz convert rfc822-to-8bit (ORCPT ); Sat, 25 Jul 2020 13:39:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726904AbgGYRjz (ORCPT ); Sat, 25 Jul 2020 13:39:55 -0400 Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBA00C08C5C0; Sat, 25 Jul 2020 10:39:54 -0700 (PDT) Received: from localhost (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id B6A361406DA; Sat, 25 Jul 2020 19:39:51 +0200 (CEST) Date: Sat, 25 Jul 2020 19:39:50 +0200 From: Marek Behun To: Andrew Lunn Cc: Pavel Machek , netdev@vger.kernel.org, linux-leds@vger.kernel.org, jacek.anaszewski@gmail.com, Dan Murphy , =?UTF-8?B?T25kxZllag==?= Jirman , Russell King , Thomas Petazzoni , Gregory Clement , linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class Message-ID: <20200725193950.20cc9732@nic.cz> In-Reply-To: <20200725150342.GG1472201@lunn.ch> References: <20200724164603.29148-1-marek.behun@nic.cz> <20200724164603.29148-3-marek.behun@nic.cz> <20200725092339.GB29492@amd> <20200725113450.0d4c936b@nic.cz> <20200725150342.GG1472201@lunn.ch> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Sat, 25 Jul 2020 17:03:42 +0200 Andrew Lunn wrote: > Does hi-z mean off? In the implementation i did, i did not list off > and on as triggers. I instead used them for untriggered > brightness. That allowed the software triggers to work, so i had the > PHY blinking the heartbeat etc. But i had to make it optional, since a > quick survey of datasheets suggested not all PHYs support simple > on/off control. I don't actually know what hi-z means, but enabling it disabled the LED. But there is another register value for OFF... > Something beyond the scope of this patchset is implementing etHool -p > > -p --identify > Initiates adapter-specific action intended to enable an operator to > easily identify the adapter by sight. Typically this involves blink‐ > ing one or more LEDs on the specific network port. > > If we have software controlled on/off, then a software trigger seems > like i good way to do this. I'll look into this. Marek