From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB9EC433E0 for ; Tue, 11 Aug 2020 22:26:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53467206DC for ; Tue, 11 Aug 2020 22:26:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726258AbgHKW0H (ORCPT ); Tue, 11 Aug 2020 18:26:07 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:42196 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbgHKW0G (ORCPT ); Tue, 11 Aug 2020 18:26:06 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id BDAFA1C0BDD; Wed, 12 Aug 2020 00:26:02 +0200 (CEST) Date: Wed, 12 Aug 2020 00:26:02 +0200 From: Pavel Machek To: Dan Murphy Cc: jacek.anaszewski@gmail.com, robh@kernel.org, marek.behun@nic.cz, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v32 2/6] leds: lp50xx: Add the LP50XX family of the RGB LED driver Message-ID: <20200811222602.GA10181@amd> References: <20200722153146.8767-1-dmurphy@ti.com> <20200722153146.8767-3-dmurphy@ti.com> <20200811105413.r2m2f7bubuz55rrt@duo.ucw.cz> <935119fa-6d1f-8e99-51f9-87966b4d03ad@ti.com> <20200811220109.GA9105@amd> <3ce38a31-a4f0-4cd7-ad09-6bdad27e6756@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="opJtzjQTFsWo+cga" Content-Disposition: inline In-Reply-To: <3ce38a31-a4f0-4cd7-ad09-6bdad27e6756@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --opJtzjQTFsWo+cga Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > >>Well it depends on where we want to create the default cache values. > >> > >>Either we run through a for..loop during driver probe and delay device = start > >>up or we keep the simple arrays and increase the driver total size. > >for loop will be better. > > > >Plus, REGCACHE_RBTREE is very likely overkill. >=20 > Well if I eliminate the reg_cache then I can eliminate the defaults too. I'm not asking for that. But please investigate REGCACHE_FLAT. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --opJtzjQTFsWo+cga Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl8zGvoACgkQMOfwapXb+vKqKwCfVq3338ANSF7hhWh4LO+FHY1M td8An2qT9W5mNi/fOLBur3okqzpJuiqH =yrsu -----END PGP SIGNATURE----- --opJtzjQTFsWo+cga--