From: Andrew Lunn <andrew@lunn.ch>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: "Pavel Machek" <pavel@ucw.cz>,
netdev@vger.kernel.org, linux-leds@vger.kernel.org,
"Dan Murphy" <dmurphy@ti.com>,
"Ondřej Jirman" <megous@megous.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org,
"Matthias Schiffer" <matthias.schiffer@ew.tq-group.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs
Date: Thu, 10 Sep 2020 16:46:53 +0200 [thread overview]
Message-ID: <20200910144653.GA3354160@lunn.ch> (raw)
In-Reply-To: <20200910161522.3cf3ad63@dellmb.labs.office.nic.cz>
> Moreover I propose (and am willing to do) this:
> Rewrite phy_led_trigger so that it registers one trigger, `phydev`.
> The identifier of the PHY which should be source of the trigger can be
> set via a separate sysfs file, `device_name`, like in netdev trigger.
> The linked speed on which the trigger should light the LED will be
> selected via sysfs file `mode` (or do you propose another name?
> `trigger_on` or something?)
>
> Example:
> # cd /sys/class/leds/<LED>
> # echo phydev >trigger
> # echo XYZ >device_name
> # cat mode
> 1Gbps 100Mbps 10Mbps
> # echo 1Gbps >mode
> # cat mode
> [1Gbps] 100Mbps 10Mbps
>
> Also the code should be moved from driver/net/phy to
> drivers/leds/trigger.
>
> The old API can be declared deprecated or removed, but outright
> removal may cause some people to complain.
This is ABI, so you cannot remove it, or change it. You can however
add to it, in a backwards compatible way.
Andrew
next prev parent reply other threads:[~2020-09-10 21:00 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 16:25 [PATCH net-next + leds v2 0/7] PLEASE REVIEW: Add support for LEDs on Marvell PHYs Marek Behún
2020-09-09 16:25 ` [PATCH net-next + leds v2 1/7] dt-bindings: leds: document binding for HW controlled LEDs Marek Behún
2020-09-09 18:27 ` Andrew Lunn
2020-09-09 18:33 ` Marek Behún
2020-09-09 20:59 ` Rob Herring
2020-09-09 21:07 ` Marek Behun
2020-09-09 21:31 ` Rob Herring
2020-09-09 21:43 ` Marek Behun
2020-09-09 20:56 ` Rob Herring
2020-09-09 21:15 ` Rob Herring
2020-09-09 21:58 ` Marek Behun
2020-09-09 16:25 ` [PATCH net-next + leds v2 2/7] leds: add generic API for LEDs that can be controlled by hardware Marek Behún
2020-09-09 18:20 ` Randy Dunlap
2020-09-09 18:31 ` Marek Behún
2020-09-09 18:43 ` Randy Dunlap
2020-09-09 20:48 ` Pavel Machek
2020-09-09 21:20 ` Marek Behun
2020-09-09 21:40 ` Pavel Machek
2020-09-09 22:15 ` Marek Behun
2020-09-09 22:20 ` Pavel Machek
2020-09-09 16:25 ` [PATCH net-next + leds v2 3/7] net: phy: add simple incrementing phyindex member to phy_device struct Marek Behún
2020-09-10 12:20 ` Pavel Machek
2020-09-09 16:25 ` [PATCH net-next + leds v2 4/7] dt-bindings: net: ethernet-phy: add description for PHY LEDs Marek Behún
2020-09-09 16:25 ` [PATCH net-next + leds v2 5/7] net: phy: add support for LEDs controlled by ethernet PHY chips Marek Behún
2020-09-10 12:22 ` Pavel Machek
2020-09-09 16:25 ` [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs Marek Behún
2020-09-10 12:23 ` Pavel Machek
2020-09-10 13:15 ` Andrew Lunn
2020-09-10 14:15 ` Marek Behún
2020-09-10 14:46 ` Andrew Lunn [this message]
2020-09-10 15:00 ` Andrew Lunn
2020-09-11 7:12 ` Matthias Schiffer
2020-09-11 12:42 ` Andrew Lunn
2020-09-11 12:52 ` Marek Behún
2020-09-10 20:23 ` Pavel Machek
2020-09-10 20:31 ` Andrew Lunn
2020-09-10 20:39 ` Pavel Machek
2020-09-10 20:41 ` Marek Behun
2020-09-10 18:24 ` Pavel Machek
2020-09-10 18:31 ` Andrew Lunn
2020-09-10 18:34 ` Russell King - ARM Linux admin
2020-09-10 20:31 ` Marek Behun
2020-09-10 21:44 ` Russell King - ARM Linux admin
2020-09-11 12:53 ` Marek Behún
2020-09-09 16:25 ` [PATCH net-next + mvebu v2 7/7] arm64: dts: armada-3720-turris-mox: add nodes for ethernet PHY LEDs Marek Behún
2020-09-10 12:25 ` Pavel Machek
2020-09-09 21:42 ` [PATCH net-next + leds v2 0/7] PLEASE REVIEW: Add support for LEDs on Marvell PHYs Andrew Lunn
2020-09-09 22:11 ` Marek Behun
2020-09-09 22:39 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910144653.GA3354160@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marek.behun@nic.cz \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=megous@megous.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).