From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4E7C433E2 for ; Thu, 10 Sep 2020 18:32:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8954C2080A for ; Thu, 10 Sep 2020 18:32:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726815AbgIJScJ (ORCPT ); Thu, 10 Sep 2020 14:32:09 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55876 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726853AbgIJScG (ORCPT ); Thu, 10 Sep 2020 14:32:06 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kGRMQ-00E6zh-Hd; Thu, 10 Sep 2020 20:31:54 +0200 Date: Thu, 10 Sep 2020 20:31:54 +0200 From: Andrew Lunn To: Pavel Machek Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , netdev@vger.kernel.org, linux-leds@vger.kernel.org, Dan Murphy , =?utf-8?Q?Ond=C5=99ej?= Jirman , Russell King , linux-kernel@vger.kernel.org, Matthias Schiffer , "David S. Miller" Subject: Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs Message-ID: <20200910183154.GF3354160@lunn.ch> References: <20200909162552.11032-1-marek.behun@nic.cz> <20200909162552.11032-7-marek.behun@nic.cz> <20200910122341.GC7907@duo.ucw.cz> <20200910131541.GD3316362@lunn.ch> <20200910182434.GA22845@duo.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200910182434.GA22845@duo.ucw.cz> Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Thu, Sep 10, 2020 at 08:24:34PM +0200, Pavel Machek wrote: > On Thu 2020-09-10 15:15:41, Andrew Lunn wrote: > > On Thu, Sep 10, 2020 at 02:23:41PM +0200, Pavel Machek wrote: > > > On Wed 2020-09-09 18:25:51, Marek Behún wrote: > > > > This patch adds support for controlling the LEDs connected to several > > > > families of Marvell PHYs via the PHY HW LED trigger API. These families > > > > are: 88E1112, 88E1121R, 88E1240, 88E1340S, 88E1510 and 88E1545. More can > > > > be added. > > > > > > > > This patch does not yet add support for compound LED modes. This could > > > > be achieved via the LED multicolor framework. > > > > > > > > Settings such as HW blink rate or pulse stretch duration are not yet > > > > supported. > > > > > > > > Signed-off-by: Marek Behún > > > > > > I suggest limiting to "useful" hardware modes, and documenting what > > > those modes do somewhere. > > > > I think to keep the YAML DT verification happy, they will need to be > > listed in the marvell PHY binding documentation. > > Well, this should really go to the sysfs documenation. Not sure what > to do with DT. In DT you can set how you want the LED to blink by default. I expect that will be the most frequent use cases, and nearly nobody will change it at runtime. > But perhaps driver can set reasonable defaults without DT input? Generally the driver will default to the hardware reset blink pattern. There are a few PHY drivers which change this at probe, but not many. The silicon defaults are pretty good. Andrew