From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E01C433E2 for ; Thu, 10 Sep 2020 20:37:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B611A214F1 for ; Thu, 10 Sep 2020 20:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726931AbgIJUhf (ORCPT ); Thu, 10 Sep 2020 16:37:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726911AbgIJUbU (ORCPT ); Thu, 10 Sep 2020 16:31:20 -0400 Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79508C061573; Thu, 10 Sep 2020 13:31:19 -0700 (PDT) Received: from localhost (unknown [IPv6:2a0e:b107:ae1:0:3e97:eff:fe61:c680]) by mail.nic.cz (Postfix) with ESMTPSA id B671E13FD86; Thu, 10 Sep 2020 22:31:12 +0200 (CEST) Date: Thu, 10 Sep 2020 22:31:12 +0200 From: Marek Behun To: Russell King - ARM Linux admin Cc: Andrew Lunn , Pavel Machek , netdev@vger.kernel.org, linux-leds@vger.kernel.org, Dan Murphy , =?UTF-8?B?T25kxZllag==?= Jirman , linux-kernel@vger.kernel.org, Matthias Schiffer , "David S. Miller" Subject: Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs Message-ID: <20200910223112.26b57dd6@nic.cz> In-Reply-To: <20200910183435.GC1551@shell.armlinux.org.uk> References: <20200909162552.11032-1-marek.behun@nic.cz> <20200909162552.11032-7-marek.behun@nic.cz> <20200910122341.GC7907@duo.ucw.cz> <20200910131541.GD3316362@lunn.ch> <20200910182434.GA22845@duo.ucw.cz> <20200910183154.GF3354160@lunn.ch> <20200910183435.GC1551@shell.armlinux.org.uk> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.102.2 at mail X-Virus-Status: Clean Sender: linux-leds-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Thu, 10 Sep 2020 19:34:35 +0100 Russell King - ARM Linux admin wrote: > On Thu, Sep 10, 2020 at 08:31:54PM +0200, Andrew Lunn wrote: > > Generally the driver will default to the hardware reset blink > > pattern. There are a few PHY drivers which change this at probe, but > > not many. The silicon defaults are pretty good. > > The "right" blink pattern can be a matter of how the hardware is > wired. For example, if you have bi-colour LEDs and the PHY supports > special bi-colour mixing modes. > Have you seen such, Russell? This could be achieved via the multicolor LED framework, but I don't have a device which uses such LEDs, so I did not write support for this in the Marvell PHY driver. (I guess I could test it though, since on my device LED0 and LED1 are used, and this to can be put into bi-colour LED mode.)