linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhen Lei <thunder.leizhen@huawei.com>
To: Rob Herring <robh+dt@kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Dan Murphy <dmurphy@ti.com>,
	linux-leds <linux-leds@vger.kernel.org>,
	Lee Jones <lee.jones@linaro.org>,
	Benson Leung <bleung@chromium.org>,
	"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
	Guenter Roeck <groeck@chromium.org>,
	Mark Brown <broonie@kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	Lubomir Rintel <lkundrak@v3.sk>,
	devicetree <devicetree@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Zhen Lei <thunder.leizhen@huawei.com>
Subject: [PATCH 3/6] spi: dt-bindings: spi-controller: explicitly require #address-cells=<0> for slave mode
Date: Wed, 14 Oct 2020 00:08:42 +0800	[thread overview]
Message-ID: <20201013160845.1772-4-thunder.leizhen@huawei.com> (raw)
In-Reply-To: <20201013160845.1772-1-thunder.leizhen@huawei.com>

scripts/dtc/checks.c:
if (get_property(node, "spi-slave"))
	spi_addr_cells = 0;
if (node_addr_cells(node) != spi_addr_cells)
	FAIL(c, dti, node, "incorrect #address-cells for SPI bus");
if (node_size_cells(node) != 0)
	FAIL(c, dti, node, "incorrect #size-cells for SPI bus");

The above code in check_spi_bus_bridge() require that the number of address
cells must be 0. So we should explicitly declare "#address-cells = <0>".

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
 .../devicetree/bindings/spi/spi-controller.yaml      | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml
index 2b154803b181c8b..1b56d5e40f1fcde 100644
--- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
+++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
@@ -20,7 +20,7 @@ properties:
     pattern: "^spi(@.*|-[0-9a-f])*$"
 
   "#address-cells":
-    const: 1
+    enum: [0, 1]
 
   "#size-cells":
     const: 0
@@ -52,11 +52,19 @@ properties:
     description:
       The SPI controller acts as a slave, instead of a master.
 
-oneOf:
-  - required:
-      - "#address-cells"
-  - required:
-      - spi-slave
+allOf:
+  - if:
+      not:
+        required:
+          - spi-slave
+    then:
+      properties:
+        "#address-cells":
+          const: 1
+    else:
+      properties:
+        "#address-cells":
+          const: 0
 
 patternProperties:
   "^slave$":
-- 
1.8.3



  parent reply	other threads:[~2020-10-13 16:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13 16:08 [PATCH 0/6] fix all errors except one reported by dt_binding_check Zhen Lei
2020-10-13 16:08 ` [PATCH 1/6] dt-bindings: leds: choose correct color value of multi-led Zhen Lei
2020-10-13 16:17   ` Dan Murphy
2020-10-13 17:04     ` Pavel Machek
2020-10-14  1:08     ` Leizhen (ThunderTown)
2020-10-13 16:08 ` [PATCH 2/6] dt-bindings: mfd: google,cros-ec: explicitly allow additional properties Zhen Lei
2020-10-13 17:53   ` Dan Murphy
2020-10-14  1:52     ` Leizhen (ThunderTown)
2020-10-14 13:38   ` Rob Herring
2020-10-15  6:55     ` Leizhen (ThunderTown)
2020-10-13 16:08 ` Zhen Lei [this message]
2020-10-14 13:41   ` [PATCH 3/6] spi: dt-bindings: spi-controller: explicitly require #address-cells=<0> for slave mode Rob Herring
2020-10-13 16:08 ` [PATCH 4/6] dt-bindings: misc: explicitly add #address-cells " Zhen Lei
2020-10-14 13:42   ` Rob Herring
2020-10-13 16:08 ` [PATCH 5/6] ARM: dts: mmp2-olpc-xo-1-75: explicitly add #address-cells=<0> " Zhen Lei
2020-10-15  9:56   ` Leizhen (ThunderTown)
2020-12-04  7:48   ` Leizhen (ThunderTown)
2020-10-13 16:08 ` [PATCH 6/6] dt-bindings: misc: correct the property name cmd-gpios to cmd-gpio Zhen Lei
2020-10-13 17:32   ` Dan Murphy
2020-10-14  1:29     ` Leizhen (ThunderTown)
2020-10-14 13:50       ` Rob Herring
2020-10-15  3:23         ` Leizhen (ThunderTown)
2020-10-16 14:13           ` Rob Herring
2020-10-15  7:12   ` Lubomir Rintel
2020-10-15  7:32     ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201013160845.1772-4-thunder.leizhen@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=bleung@chromium.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=enric.balletbo@collabora.com \
    --cc=groeck@chromium.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=lkundrak@v3.sk \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).