From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D168BC433DB for ; Tue, 23 Feb 2021 09:00:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8647664DDA for ; Tue, 23 Feb 2021 09:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230223AbhBWJAo (ORCPT ); Tue, 23 Feb 2021 04:00:44 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:51708 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231143AbhBWJAm (ORCPT ); Tue, 23 Feb 2021 04:00:42 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 3208B1C0B85; Tue, 23 Feb 2021 10:00:00 +0100 (CET) Date: Tue, 23 Feb 2021 09:59:59 +0100 From: Pavel Machek To: Hans de Goede Cc: Jiri Kosina , Benjamin Tissoires , linux-input@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v2 1/7] HID: lenovo: Use brightness_set_blocking callback for setting LEDs brightness Message-ID: <20210223085959.GC9750@amd> References: <20210220122438.21857-1-hdegoede@redhat.com> <20210220122438.21857-2-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="RIYY1s2vRbPFwWeW" Content-Disposition: inline In-Reply-To: <20210220122438.21857-2-hdegoede@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --RIYY1s2vRbPFwWeW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat 2021-02-20 13:24:32, Hans de Goede wrote: > The lenovo_led_brightness_set function may sleep, so we should have the > the led_class_dev's brightness_set_blocking callback point to it, rather > then the regular brightness_set callback. >=20 > When toggle through sysfs this is not a problem, but the brightness_set > callback may be called from atomic context when using LED-triggers. >=20 > Fixes: bc04b37ea0ec ("HID: lenovo: Add ThinkPad 10 Ultrabook Keyboard sup= port") > Signed-off-by: Hans de Goede Acked-by: Pavel Machek Pavel --=20 http://www.livejournal.com/~pavelmachek --RIYY1s2vRbPFwWeW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmA0xA8ACgkQMOfwapXb+vJh4QCguJNZSG9GaVKowh+jJjCtEDfQ 04MAoK6hH6jZdSaulTwWF2RVp7Pz9Z2X =L+UJ -----END PGP SIGNATURE----- --RIYY1s2vRbPFwWeW--