From: Pavel Machek <pavel@ucw.cz>
To: Henning Schild <henning.schild@siemens.com>
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
linux-watchdog@vger.kernel.org,
Srikanth Krishnakar <skrishnakar@gmail.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Gerd Haeussler <gerd.haeussler.ext@siemens.com>,
Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Mark Gross <mgross@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs
Date: Wed, 3 Mar 2021 20:27:33 +0100 [thread overview]
Message-ID: <20210303192733.GA8720@amd> (raw)
In-Reply-To: <20210303194956.5b36a73c@md1za8fc.ad001.siemens.net>
[-- Attachment #1: Type: text/plain, Size: 1389 bytes --]
On Wed 2021-03-03 19:49:56, Henning Schild wrote:
> Am Wed, 3 Mar 2021 18:40:40 +0100
> schrieb Pavel Machek <pavel@ucw.cz>:
>
> > Hi!
> >
> > > > > diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
> > > > > index 2a698df9da57..c15e1e3c5958 100644
> > > > > --- a/drivers/leds/Makefile
> > > > > +++ b/drivers/leds/Makefile
> > > > > @@ -93,6 +93,7 @@ obj-$(CONFIG_LEDS_TURRIS_OMNIA)
> > > > > += leds-turris-omnia.o
> > > > > obj-$(CONFIG_LEDS_WM831X_STATUS) += leds-wm831x-status.o
> > > > > obj-$(CONFIG_LEDS_WM8350) += leds-wm8350.o
> > > > > obj-$(CONFIG_LEDS_WRAP) += leds-wrap.o
> > > > > +obj-$(CONFIG_LEDS_SIEMENS_SIMATIC_IPC) +=
> > > > > simatic-ipc-leds.o
> > > >
> > > > Let's put this into drivers/leds/simple. You'll have to create
> > > > it.
> > >
> > > Can you please go into detail why? We plan to add more devices in
> > > the future, which might in fact make this a little less simple. But
> > > we can discuss that when the time is right and start with simple.
> >
> > There's already way too many drivers in the directory, and your driver
> > is very different from drivers for camera flash (for example).
>
> Understood, the whole Makefile Kconfig thingy?
You'll need Makefile + Kconfig, yes. No need for CONFIG_LEDS_SIMPLE.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-03-04 0:07 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 16:33 [PATCH 0/4] add device drivers for Siemens Industrial PCs Henning Schild
2021-03-02 16:33 ` [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices Henning Schild
2021-03-04 10:11 ` Andy Shevchenko
2021-03-04 13:47 ` Hans de Goede
2021-03-05 15:42 ` Andy Shevchenko
2021-03-05 16:14 ` Hans de Goede
2021-03-05 16:25 ` Andy Shevchenko
2021-03-05 16:36 ` Hans de Goede
2021-03-05 16:41 ` Andy Shevchenko
2021-03-05 16:47 ` Andy Shevchenko
2021-03-05 16:42 ` Henning Schild
2021-03-05 17:17 ` Andy Shevchenko
2021-03-05 17:44 ` Andy Shevchenko
2021-03-08 12:57 ` Henning Schild
2021-03-08 13:43 ` Andy Shevchenko
2021-03-04 19:42 ` Henning Schild
2021-03-05 15:46 ` Andy Shevchenko
2021-03-05 16:31 ` Henning Schild
2021-03-04 14:03 ` Hans de Goede
2021-03-02 16:33 ` [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs Henning Schild
2021-03-02 20:54 ` Pavel Machek
2021-03-03 13:11 ` Henning Schild
2021-03-03 19:31 ` Pavel Machek
2021-03-03 20:48 ` Henning Schild
2021-03-03 20:56 ` Henning Schild
2021-03-05 18:25 ` Henning Schild
2021-03-06 12:54 ` Henning Schild
2021-03-06 13:06 ` Henning Schild
2021-03-15 11:49 ` Pavel Machek
2021-03-15 11:41 ` Pavel Machek
2021-03-03 17:37 ` Henning Schild
2021-03-03 17:40 ` Pavel Machek
2021-03-03 18:49 ` Henning Schild
2021-03-03 19:27 ` Pavel Machek [this message]
2021-03-02 16:33 ` [PATCH 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs Henning Schild
2021-03-02 18:38 ` Guenter Roeck
2021-03-03 14:21 ` Henning Schild
2021-03-03 14:49 ` Jan Kiszka
2021-03-08 15:20 ` Henning Schild
[not found] ` <CAHp75VdUXWDg-2o8fmeo7EoMtRLfCnFOw5ptwjXTv9fKMmHv2A@mail.gmail.com>
2021-03-04 9:00 ` Henning Schild
2021-03-02 16:33 ` [PATCH 4/4] platform/x86: pmc_atom: improve critclk_systems matching for Siemens PCs Henning Schild
2021-03-04 9:50 ` Andy Shevchenko
2021-03-04 10:19 ` [PATCH 0/4] add device drivers for Siemens Industrial PCs Andy Shevchenko
2021-03-04 10:20 ` Andy Shevchenko
2021-03-04 19:26 ` Henning Schild
2021-03-04 19:14 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303192733.GA8720@amd \
--to=pavel@ucw.cz \
--cc=gerd.haeussler.ext@siemens.com \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=skrishnakar@gmail.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).