From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 673AAC43603 for ; Wed, 3 Mar 2021 23:59:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 330B964F64 for ; Wed, 3 Mar 2021 23:59:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234957AbhCCX7y (ORCPT ); Wed, 3 Mar 2021 18:59:54 -0500 Received: from lizzard.sbs.de ([194.138.37.39]:35476 "EHLO lizzard.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1388063AbhCCUta (ORCPT ); Wed, 3 Mar 2021 15:49:30 -0500 Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id 123KmOxH011929 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 3 Mar 2021 21:48:24 +0100 Received: from md1za8fc.ad001.siemens.net ([139.22.36.86]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id 123KmNG7020262; Wed, 3 Mar 2021 21:48:23 +0100 Date: Wed, 3 Mar 2021 21:48:21 +0100 From: Henning Schild To: Pavel Machek Cc: , , , , Srikanth Krishnakar , Jan Kiszka , Gerd Haeussler , Guenter Roeck , Wim Van Sebroeck , Mark Gross , Hans de Goede Subject: Re: [PATCH 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs Message-ID: <20210303214810.511ad65a@md1za8fc.ad001.siemens.net> In-Reply-To: <20210303193134.GB8720@amd> References: <20210302163309.25528-1-henning.schild@siemens.com> <20210302163309.25528-3-henning.schild@siemens.com> <20210302205452.GA32573@duo.ucw.cz> <20210303141052.30641e6b@md1za8fc.ad001.siemens.net> <20210303193134.GB8720@amd> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org Am Wed, 3 Mar 2021 20:31:34 +0100 schrieb Pavel Machek : > Hi! > > > > > +static struct simatic_ipc_led simatic_ipc_leds_io[] = { > > > > + {1 << 15, "simatic-ipc:green:run-stop"}, > > > > + {1 << 7, "simatic-ipc:yellow:run-stop"}, > > > > + {1 << 14, "simatic-ipc:red:error"}, > > > > + {1 << 6, "simatic-ipc:yellow:error"}, > > > > + {1 << 13, "simatic-ipc:red:maint"}, > > > > + {1 << 5, "simatic-ipc:yellow:maint"}, > > > > + {0, ""}, > > > > +}; > > > > > > Please use names consistent with other systems, this is user > > > visible. If you have two-color power led, it should be > > > :green:power... See include/dt-bindings/leds/common.h . > > > > Well we wanted to pick names that are printed on the devices and > > would like to stick to those. Has been a discussion ... > > Can we have symlinks to have multiple names per LED? > > No symlinks. We plan to have command line tool to manipulate LEDs, > aliases might be possible there. Sounds like a future plan. sysfs and "cat" "echo" are mighty tools and "everything is a file" is the best idea ever. So i would say any aliasing should live in the kernel, but that is just me. Tools will just get out of sync, be missing in busybox or a random yocto ... or whichever distro you like. On the other hand you have "complexity should be userland" ... i do not have the answer. > > How strong would you feel about us using our names? > > Strongly. :-) OK, will try to find a match where possible. > Do you have a picture how the leds look like? I could even find chassis photos in our internal review but that would be too much. Our idea is probably the same as yours. We want the same names across all devices. But we struggle with colors because on some boxes we have red+green, while other offer yellow ... implemented in HW and messing with red+green in some cases. But so far we only looked at Siemens devices and thought we could get our own "namespace". To be honest i could not even tell how our names map on the known ones, but we will do our best to find a match. They all are "high-level" so "power" and other basic things are not exposed. regards, Henning > Best regards, > Pavel