Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] leds: LEDS_BLINK_LGM should depend on X86
@ 2021-03-16 13:39 Geert Uytterhoeven
  2021-04-25 20:57 ` Pavel Machek
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-03-16 13:39 UTC (permalink / raw)
  To: Pavel Machek, Dan Murphy, Amireddy Mallikarjuna reddy
  Cc: Arnd Bergmann, linux-leds, linux-kernel, Geert Uytterhoeven

The Intel Lightning Mountain (LGM) Serial Shift Output controller (SSO)
is only present on Intel Lightning Mountain SoCs.  Hence add a
dependency on X86, to prevent asking the user about this driver when
configuring a kernel without Intel Lightning Mountain platform support.

While at it, merge the other dependencies into a single statement.

Fixes: c3987cd2bca34ddf ("leds: lgm: Add LED controller driver for LGM SoC")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/leds/blink/Kconfig | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 6dedc58c47b3ea16..852e634002cda7cf 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -9,10 +9,8 @@ if LEDS_BLINK
 
 config LEDS_BLINK_LGM
 	tristate "LED support for Intel LGM SoC series"
-	depends on GPIOLIB
-	depends on LEDS_CLASS
-	depends on MFD_SYSCON
-	depends on OF
+	depends on X86 || COMPILE_TEST
+	depends on GPIOLIB && LEDS_CLASS && MFD_SYSCON && OF
 	help
 	  Parallel to serial conversion, which is also called SSO controller,
 	  can drive external shift register for LED outputs.
-- 
2.25.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] leds: LEDS_BLINK_LGM should depend on X86
  2021-03-16 13:39 [PATCH] leds: LEDS_BLINK_LGM should depend on X86 Geert Uytterhoeven
@ 2021-04-25 20:57 ` Pavel Machek
  2021-04-26  7:06   ` Geert Uytterhoeven
  0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2021-04-25 20:57 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Dan Murphy, Amireddy Mallikarjuna reddy, Arnd Bergmann,
	linux-leds, linux-kernel


[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

Hi!

> The Intel Lightning Mountain (LGM) Serial Shift Output controller (SSO)
> is only present on Intel Lightning Mountain SoCs.  Hence add a
> dependency on X86, to prevent asking the user about this driver when
> configuring a kernel without Intel Lightning Mountain platform support.
> 
> While at it, merge the other dependencies into a single statement.
> 
> Fixes: c3987cd2bca34ddf ("leds: lgm: Add LED controller driver for LGM SoC")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

This rejected, so I applied it by hand. I'm deleting the Fixes tag --
we don't want this in stable.

Thanks and best regards,
							Pavel

-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] leds: LEDS_BLINK_LGM should depend on X86
  2021-04-25 20:57 ` Pavel Machek
@ 2021-04-26  7:06   ` Geert Uytterhoeven
  2021-04-27  9:12     ` Pavel Machek
  0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-04-26  7:06 UTC (permalink / raw)
  To: Pavel Machek
  Cc: Dan Murphy, Amireddy Mallikarjuna reddy, Arnd Bergmann,
	linux-leds, Linux Kernel Mailing List

Hi Pavel,

On Sun, Apr 25, 2021 at 10:57 PM Pavel Machek <pavel@ucw.cz> wrote:
> > The Intel Lightning Mountain (LGM) Serial Shift Output controller (SSO)
> > is only present on Intel Lightning Mountain SoCs.  Hence add a
> > dependency on X86, to prevent asking the user about this driver when
> > configuring a kernel without Intel Lightning Mountain platform support.
> >
> > While at it, merge the other dependencies into a single statement.
> >
> > Fixes: c3987cd2bca34ddf ("leds: lgm: Add LED controller driver for LGM SoC")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> This rejected, so I applied it by hand.

Thank you!

> I'm deleting the Fixes tag --
> we don't want this in stable.

Why not? Shouldn't people running stable be shielded from useless
questions while configuring their kernels?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] leds: LEDS_BLINK_LGM should depend on X86
  2021-04-26  7:06   ` Geert Uytterhoeven
@ 2021-04-27  9:12     ` Pavel Machek
  0 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2021-04-27  9:12 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Dan Murphy, Amireddy Mallikarjuna reddy, Arnd Bergmann,
	linux-leds, Linux Kernel Mailing List


[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

On Mon 2021-04-26 09:06:16, Geert Uytterhoeven wrote:
> Hi Pavel,
> 
> On Sun, Apr 25, 2021 at 10:57 PM Pavel Machek <pavel@ucw.cz> wrote:
> > > The Intel Lightning Mountain (LGM) Serial Shift Output controller (SSO)
> > > is only present on Intel Lightning Mountain SoCs.  Hence add a
> > > dependency on X86, to prevent asking the user about this driver when
> > > configuring a kernel without Intel Lightning Mountain platform support.
> > >
> > > While at it, merge the other dependencies into a single statement.
> > >
> > > Fixes: c3987cd2bca34ddf ("leds: lgm: Add LED controller driver for LGM SoC")
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > This rejected, so I applied it by hand.
> 
> Thank you!
> 
> > I'm deleting the Fixes tag --
> > we don't want this in stable.
> 
> Why not? Shouldn't people running stable be shielded from useless
> questions while configuring their kernels?

See stable-kernel-rules. (Maybe updating them to match recent reality
would be better, but...)

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 13:39 [PATCH] leds: LEDS_BLINK_LGM should depend on X86 Geert Uytterhoeven
2021-04-25 20:57 ` Pavel Machek
2021-04-26  7:06   ` Geert Uytterhoeven
2021-04-27  9:12     ` Pavel Machek

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org
	public-inbox-index linux-leds

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git