From: Pavel Machek <pavel@ucw.cz>
To: Rahul Tanwar <rtanwar@maxlinear.com>
Cc: arnd@kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org, kilobyte@angband.pl,
rafael.j.wysocki@intel.com, john@phrozen.org,
hmehrtens@maxlinear.com, ckim@maxlinear.com, qwu@maxlinear.com
Subject: Re: [PATCH v2 1/1] leds: lgm: Improve Kconfig help
Date: Thu, 25 Mar 2021 11:40:55 +0100 [thread overview]
Message-ID: <20210325104055.GA7247@amd> (raw)
In-Reply-To: <468455e66ce27bc731fab08be8aeccedba2ed342.1616655898.git.rtanwar@maxlinear.com>
[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]
Hi!
> Remove unnecessary Kconfig symbol LEDS_BLINK
> Improve Kconfig help text to make it more useful.
>
> Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
Thanks for the patch, I applied it by hand.
> +++ b/drivers/leds/blink/leds-lgm-sso.c
> @@ -1,8 +1,8 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> - * Intel Lightning Mountain SoC LED Serial Shift Output Controller driver
> + * Lightning Mountain SoC LED Serial Shift Output Controller driver
> *
> - * Copyright (c) 2020 Intel Corporation.
> + * Copyright (c) 2021 Intel Corporation.
> */
>
Not taking this. Talk to your lawyers why.
> This electronic mail (including any attachments) may contain
information that is privileged, confidential, and/or otherwise
protected from disclosure to anyone other than its intended
recipient(s). Any dissemination or use of this electronic mail or
its contents (including any attachments) by persons other than the
intended recipient(s) is strictly prohibited. If you have received
this message in error, please notify us immediately by reply e-mail
so that we may correct our internal records. Please then delete the
original message (including any attachments) in its entirety.
And talk to them about this, too.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2021-03-25 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 7:11 [PATCH v2 0/1] leds: lgm: Address review concerns Rahul Tanwar
2021-03-25 7:11 ` [PATCH v2 1/1] leds: lgm: Improve Kconfig help Rahul Tanwar
2021-03-25 10:40 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325104055.GA7247@amd \
--to=pavel@ucw.cz \
--cc=arnd@kernel.org \
--cc=ckim@maxlinear.com \
--cc=hmehrtens@maxlinear.com \
--cc=john@phrozen.org \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=qwu@maxlinear.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rtanwar@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).