Linux-LEDs Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2 0/1] leds: lgm: Address review concerns
@ 2021-03-25  7:11 Rahul Tanwar
  2021-03-25  7:11 ` [PATCH v2 1/1] leds: lgm: Improve Kconfig help Rahul Tanwar
  0 siblings, 1 reply; 3+ messages in thread
From: Rahul Tanwar @ 2021-03-25  7:11 UTC (permalink / raw)
  To: pavel
  Cc: arnd, linux-leds, linux-kernel, kilobyte, rafael.j.wysocki, john,
	hmehrtens, ckim, qwu, Rahul Tanwar

Address below review concerns from Pavel:
1. Remove LEDS_BLINK Kconfig symbol.
2. Provide useful Kconfig help text for the driver.

This patch is based on "for-next" branch of kernel from below git tree:
git git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next

v2:
- Fix few code quality related review concerns (Randy Dunlap).
- Further improve Kconfig help text (Pavel).
- Switch back to original copyright (pavel).

v1:
- Initial version.

Rahul Tanwar (1):
  leds: lgm: Improve Kconfig help

 drivers/leds/Kconfig              |  5 ++---
 drivers/leds/Makefile             |  2 +-
 drivers/leds/blink/Kconfig        | 28 +++++++++++++---------------
 drivers/leds/blink/Makefile       |  2 +-
 drivers/leds/blink/leds-lgm-sso.c |  4 ++--
 5 files changed, 19 insertions(+), 22 deletions(-)

--
2.17.1

________________________________

This electronic mail (including any attachments) may contain information that is privileged, confidential, and/or otherwise protected from disclosure to anyone other than its intended recipient(s). Any dissemination or use of this electronic mail or its contents (including any attachments) by persons other than the intended recipient(s) is strictly prohibited. If you have received this message in error, please notify us immediately by reply e-mail so that we may correct our internal records. Please then delete the original message (including any attachments) in its entirety.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 1/1] leds: lgm: Improve Kconfig help
  2021-03-25  7:11 [PATCH v2 0/1] leds: lgm: Address review concerns Rahul Tanwar
@ 2021-03-25  7:11 ` Rahul Tanwar
  2021-03-25 10:40   ` Pavel Machek
  0 siblings, 1 reply; 3+ messages in thread
From: Rahul Tanwar @ 2021-03-25  7:11 UTC (permalink / raw)
  To: pavel
  Cc: arnd, linux-leds, linux-kernel, kilobyte, rafael.j.wysocki, john,
	hmehrtens, ckim, qwu, Rahul Tanwar

Remove unnecessary Kconfig symbol LEDS_BLINK
Improve Kconfig help text to make it more useful.

Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>
---
 drivers/leds/Kconfig              |  5 ++---
 drivers/leds/Makefile             |  2 +-
 drivers/leds/blink/Kconfig        | 28 +++++++++++++---------------
 drivers/leds/blink/Makefile       |  2 +-
 drivers/leds/blink/leds-lgm-sso.c |  4 ++--
 5 files changed, 19 insertions(+), 22 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index b6742b4231bf..4ca8cd594518 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -928,13 +928,12 @@ config LEDS_ACER_A500
          This option enables support for the Power Button LED of
          Acer Iconia Tab A500.

+source "drivers/leds/blink/Kconfig"
+
 comment "Flash and Torch LED drivers"
 source "drivers/leds/flash/Kconfig"

 comment "LED Triggers"
 source "drivers/leds/trigger/Kconfig"

-comment "LED Blink"
-source "drivers/leds/blink/Kconfig"
-
 endif # NEW_LEDS
diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile
index 2a698df9da57..7e604d3028c8 100644
--- a/drivers/leds/Makefile
+++ b/drivers/leds/Makefile
@@ -110,4 +110,4 @@ obj-$(CONFIG_LEDS_CLASS_FLASH)              += flash/
 obj-$(CONFIG_LEDS_TRIGGERS)            += trigger/

 # LED Blink
-obj-$(CONFIG_LEDS_BLINK)                += blink/
+obj-y                                  += blink/
diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 6dedc58c47b3..8a11f9acd1a7 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -1,21 +1,19 @@
-menuconfig LEDS_BLINK
-       bool "LED Blink support"
-       depends on LEDS_CLASS
-       help
-         This option enables blink support for the leds class.
-         If unsure, say Y.
-
-if LEDS_BLINK
-
-config LEDS_BLINK_LGM
-       tristate "LED support for Intel LGM SoC series"
+config LEDS_LGM
+       tristate "LED support for LGM SoC series"
        depends on GPIOLIB
        depends on LEDS_CLASS
        depends on MFD_SYSCON
        depends on OF
        help
-         Parallel to serial conversion, which is also called SSO controller,
-         can drive external shift register for LED outputs.
-         This enables LED support for Serial Shift Output controller(SSO).
+         This option enables support for LEDs connected to GPIO lines on
+         Lightning Mountain (LGM) SoC. Lightning Mountain is a AnyWAN
+         gateway-on-a-chip SoC to be shipped on mid and high end home
+         gateways and routers.
+
+         These LEDs are driven by a Serial Shift Output (SSO) controller.
+         The driver supports hardware blinking and the LEDs can be configured
+         to be triggered by software/CPU or by hardware.

-endif # LEDS_BLINK
+         Say 'Y' here if you are working on LGM SoC based platform. Otherwise,
+         say 'N'. To compile this driver as a module, choose M here: the module
+         will be called leds-lgm-sso.
diff --git a/drivers/leds/blink/Makefile b/drivers/leds/blink/Makefile
index 2fa6c7b7b67e..fa5d04dccf13 100644
--- a/drivers/leds/blink/Makefile
+++ b/drivers/leds/blink/Makefile
@@ -1,2 +1,2 @@
 # SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_LEDS_BLINK_LGM)   += leds-lgm-sso.o
+obj-$(CONFIG_LEDS_LGM) += leds-lgm-sso.o
diff --git a/drivers/leds/blink/leds-lgm-sso.c b/drivers/leds/blink/leds-lgm-sso.c
index 7d5c9ca007d6..e78792c90117 100644
--- a/drivers/leds/blink/leds-lgm-sso.c
+++ b/drivers/leds/blink/leds-lgm-sso.c
@@ -1,8 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0
 /*
- * Intel Lightning Mountain SoC LED Serial Shift Output Controller driver
+ * Lightning Mountain SoC LED Serial Shift Output Controller driver
  *
- * Copyright (c) 2020 Intel Corporation.
+ * Copyright (c) 2021 Intel Corporation.
  */

 #include <linux/bitfield.h>
--
2.17.1

________________________________

This electronic mail (including any attachments) may contain information that is privileged, confidential, and/or otherwise protected from disclosure to anyone other than its intended recipient(s). Any dissemination or use of this electronic mail or its contents (including any attachments) by persons other than the intended recipient(s) is strictly prohibited. If you have received this message in error, please notify us immediately by reply e-mail so that we may correct our internal records. Please then delete the original message (including any attachments) in its entirety.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 1/1] leds: lgm: Improve Kconfig help
  2021-03-25  7:11 ` [PATCH v2 1/1] leds: lgm: Improve Kconfig help Rahul Tanwar
@ 2021-03-25 10:40   ` Pavel Machek
  0 siblings, 0 replies; 3+ messages in thread
From: Pavel Machek @ 2021-03-25 10:40 UTC (permalink / raw)
  To: Rahul Tanwar
  Cc: arnd, linux-leds, linux-kernel, kilobyte, rafael.j.wysocki, john,
	hmehrtens, ckim, qwu


[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

Hi!

> Remove unnecessary Kconfig symbol LEDS_BLINK
> Improve Kconfig help text to make it more useful.
> 
> Signed-off-by: Rahul Tanwar <rtanwar@maxlinear.com>

Thanks for the patch, I applied it by hand.

> +++ b/drivers/leds/blink/leds-lgm-sso.c
> @@ -1,8 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Intel Lightning Mountain SoC LED Serial Shift Output Controller driver
> + * Lightning Mountain SoC LED Serial Shift Output Controller driver
>   *
> - * Copyright (c) 2020 Intel Corporation.
> + * Copyright (c) 2021 Intel Corporation.
>   */
> 

Not taking this. Talk to your lawyers why.

> This electronic mail (including any attachments) may contain
  information that is privileged, confidential, and/or otherwise
  protected from disclosure to anyone other than its intended
  recipient(s). Any dissemination or use of this electronic mail or
  its contents (including any attachments) by persons other than the
  intended recipient(s) is strictly prohibited. If you have received
  this message in error, please notify us immediately by reply e-mail
  so that we may correct our internal records. Please then delete the
  original message (including any attachments) in its entirety.

And talk to them about this, too.

Best regards,
								Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-25  7:11 [PATCH v2 0/1] leds: lgm: Address review concerns Rahul Tanwar
2021-03-25  7:11 ` [PATCH v2 1/1] leds: lgm: Improve Kconfig help Rahul Tanwar
2021-03-25 10:40   ` Pavel Machek

Linux-LEDs Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \
		linux-leds@vger.kernel.org
	public-inbox-index linux-leds

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git