From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E829C433B4 for ; Fri, 30 Apr 2021 13:41:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BBFA61424 for ; Fri, 30 Apr 2021 13:41:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbhD3NmG (ORCPT ); Fri, 30 Apr 2021 09:42:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbhD3NmG (ORCPT ); Fri, 30 Apr 2021 09:42:06 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 622CFC06174A for ; Fri, 30 Apr 2021 06:41:18 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id u16so52711609oiu.7 for ; Fri, 30 Apr 2021 06:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hxOtwSZu4oEXP0BEqDSu+lmsVsdNjWZtq/yvaEq4ie0=; b=JQ8qNnJl3RfX3lhvLSC+wnbDqnYYVFDJWbbOG4C+0LYqhNoRHmZ+ioxoTRGC+KZtOt OE+5o7YEmQMcVUUqXFonjBV4PTTBiOO5X5g0W+q6wcD6aovjiphKAH4AAcdzemc7P/jR ST6oCTs2kykhuNhnL8iN5HvhXDh6jtmNunwyu1ZGtbXQgPHYAqKW4Oj6E0Bcqj6s27G/ zURFAt3QoKpQx76XYQfgfVbkeN8sVDVRtTw1JI5lysWt1VDH6S+cyNs1mMvQXusMoXei 5bbzP4aC7sdV/cfG0dGvAhnJkTo3cxk5nhbPvD1zehC/MFpzwuFUqmlLN+P9alBlx1Jp V+Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hxOtwSZu4oEXP0BEqDSu+lmsVsdNjWZtq/yvaEq4ie0=; b=hQjq/9k4KGz+7q2LxryG+tw+X+R0n53Ua1TssfxO6gDIxuCE6VSoomaJseQNy9/FAt Mf7TehpzG0L80RbJH+EfFGz0wXCVkdUp2TcdRXxuhuGMPg5s+5cJ0IPI6dAZ7Z8iCkDz F3GMlDQY7kSrrFjWa7gx0WV1helbMioMxhOPIcrE/NxKCv4SKtGMhdSqmDGwIQT7XpZF NZ/P6UrK0n2E1k0p+64H0zH49juKvB4P+ksq1S7MsJdTgFJMIvIc3ws2qcJpyp8PSzz2 +64S3MYfdPveSpRuwF6WuyGgq65dE9vp5vpKdPROm4TqEdmnk2yseMEd5uKE7X56Dql1 z5Hw== X-Gm-Message-State: AOAM530b6A+xxTyfYqYcAqCly38Sh4frwBTU9MTfiH8u6HpQGpg9LJVO 52g0pvjez1MiCJiK4XN3Kc1Y9PoIDIWJUQ== X-Google-Smtp-Source: ABdhPJzH74O4u7xM2xkFSoVY6BhPTcqN8QNcwgEy8zbUY9H0znIBwNBVvsog6sltP4mPQVJFPxVzOQ== X-Received: by 2002:aca:5856:: with SMTP id m83mr3949232oib.105.1619790077632; Fri, 30 Apr 2021 06:41:17 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id z204sm205246oia.2.2021.04.30.06.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 06:41:17 -0700 (PDT) Date: Fri, 30 Apr 2021 08:41:14 -0500 From: Bjorn Andersson To: Marijn Suijten Cc: linux-leds@vger.kernel.org, Pavel Machek , linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: ledtrig-pattern: Use last_repeat when applying hw pattern Message-ID: <20210430134114.GC2484@yoga> References: <20210418213427.220638-1-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210418213427.220638-1-marijn.suijten@somainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Sun 18 Apr 16:34 CDT 2021, Marijn Suijten wrote: > `last_repeat` holds the actual value requested by the user whereas > `repeat` is a software iteration variable that is unused in hardware > patterns. > > Furthermore `last_repeat` is the field returned to the user when reading > the `repeat` sysfs property. This field is initialized to `-1` which is > - together with `1` - the only valid value in the upcoming Qualcomm LPG > driver. It is thus unexpected when `repeat` with an initialization > value of `0` is passed into the the driver, when the sysfs property > clearly presents a value of `-1`. > Reviewed-by: Bjorn Andersson Tested-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Marijn Suijten > --- > drivers/leds/trigger/ledtrig-pattern.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/leds/trigger/ledtrig-pattern.c b/drivers/leds/trigger/ledtrig-pattern.c > index 4d138d5317e9..2853b75df338 100644 > --- a/drivers/leds/trigger/ledtrig-pattern.c > +++ b/drivers/leds/trigger/ledtrig-pattern.c > @@ -126,7 +126,8 @@ static int pattern_trig_start_pattern(struct led_classdev *led_cdev) > > if (data->is_hw_pattern) { > return led_cdev->pattern_set(led_cdev, data->patterns, > - data->npatterns, data->repeat); > + data->npatterns, > + data->last_repeat); > } > > /* At least 2 tuples for software pattern. */ > -- > 2.31.1 >