From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 446A6C433ED for ; Wed, 5 May 2021 05:22:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CBFC613C3 for ; Wed, 5 May 2021 05:22:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231602AbhEEFWz (ORCPT ); Wed, 5 May 2021 01:22:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231265AbhEEFWy (ORCPT ); Wed, 5 May 2021 01:22:54 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0AC17C061574 for ; Tue, 4 May 2021 22:21:59 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1le9ys-0005HJ-1e; Wed, 05 May 2021 07:21:54 +0200 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1le9yr-00047w-6W; Wed, 05 May 2021 07:21:53 +0200 Date: Wed, 5 May 2021 07:21:53 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Bjorn Andersson Cc: Pavel Machek , Thierry Reding , Lee Jones , Dan Murphy , Rob Herring , Andy Gross , Martin Botka , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH v6 2/4] leds: Add driver for Qualcomm LPG Message-ID: <20210505052153.syhptme4pfrbw73v@pengutronix.de> References: <20201021201224.3430546-1-bjorn.andersson@linaro.org> <20201021201224.3430546-3-bjorn.andersson@linaro.org> <20201029181357.GE26053@duo.ucw.cz> <20210429211223.GA5480@amd> <20210429212920.GB2484@yoga> <20210504161327.GF2484@yoga> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="twdyeagubu6upt4z" Content-Disposition: inline In-Reply-To: <20210504161327.GF2484@yoga> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-leds@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org --twdyeagubu6upt4z Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Tue, May 04, 2021 at 11:13:27AM -0500, Bjorn Andersson wrote: > On Tue 04 May 10:43 CDT 2021, Pavel Machek wrote: > > > So downstream they have (last time I looked at the code) an addition = in > > > the PWM API where the LED driver can inform the PWM driver part about > > > the indices to use. Naturally I don't think that's a good idea. > >=20 > > Dunno. Is it bad idea? > >=20 > > pattern support for other PWMs (vibration?) seems useful, too. Yes, it > > means more discussion and extending PWMs properly.. > >=20 >=20 > @Thierry, @Lee, @Uwe, are you interested in extending the PWM api with > some sort of support for specifying an array of "duty_cycle" and some > property for how fast the hardware should cycle through those duty > cycles? (And I need a bit/bool to indicate if the pattern should run > once of be repeated) >=20 > The (current) use case relates to being able to alter the duty cycle > over time to create "effects" such as pulsing an LED. My personal opinion here is that this is too special to be worth the generalisation. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --twdyeagubu6upt4z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmCSK20ACgkQwfwUeK3K 7AnbuQf9FCB0PpgSA/lR/qkTwcyn5aszc/HWkQpesYZyNI/WCfvWF9/stR+usSRk +nGaH75A/vzYqc91kOyGIxxBdAXF/6nwuaVlf7bqAnv7ik7fsBDNxdB8TGRlxaMe BqEn9OGkicUoKce8jEdXnvtWHNEydIyIwnddviu9XXuuuzyeoW4rLqViWDRfTxSc 3lpyxoTyylKO+giIoB3LIdfAu7N+zs61WBpwaUgH/hdDJ0ZAI5Nyluqkui4gcsht 02x0bxWbl/wbpXPWTz/Sx3BW9zrZk3k/uKZSFPYNxm3rZmOF4I+HhbMA5/FrkSub LBDp5Vds0xUF2QtsuDfPv3JWexGoJQ== =v6gl -----END PGP SIGNATURE----- --twdyeagubu6upt4z--