linux-leds.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: leds: document rfkill default action
@ 2021-09-19 15:14 David Heidelberg
  2021-09-19 20:38 ` Marek Behún
  0 siblings, 1 reply; 2+ messages in thread
From: David Heidelberg @ 2021-09-19 15:14 UTC (permalink / raw)
  To: Pavel Machek, Rob Herring, Jacek Anaszewski
  Cc: linux-leds, devicetree, linux-kernel, David Heidelberg

Used only in Toshiba AC100 / Dynabook AZ, but throws ugly warning:
arch/arm/boot/dts/tegra20-paz00.dt.yaml: gpio-leds: led-0:linux,default-trigger:0: 'rfkill0' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 Documentation/devicetree/bindings/leds/common.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index 697102707703..d3814e6bf3cf 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -96,6 +96,8 @@ properties:
       - timer
         # LED alters the brightness for the specified duration with one software
         # timer (requires "led-pattern" property)
+      - rfkill0
+        # LED indicates rfkill state
       - pattern
 
   led-pattern:
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: leds: document rfkill default action
  2021-09-19 15:14 [PATCH] dt-bindings: leds: document rfkill default action David Heidelberg
@ 2021-09-19 20:38 ` Marek Behún
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Behún @ 2021-09-19 20:38 UTC (permalink / raw)
  To: David Heidelberg
  Cc: Pavel Machek, Rob Herring, Jacek Anaszewski, linux-leds,
	devicetree, linux-kernel

On Sun, 19 Sep 2021 17:14:44 +0200
David Heidelberg <david@ixit.cz> wrote:

> +      - rfkill0

And why does Toshiba AC100 / Dynabook AZ driver need the zero at the
end??

Is this a private trigger? There is no such trigger driver in
drivers/leds/triggrer.

Anyway `linux,default-trigger` property is deprecated. Can't Toshiba
AC100 / Dynabook AZ be merged to the `function` property?

Marek

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-19 20:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-19 15:14 [PATCH] dt-bindings: leds: document rfkill default action David Heidelberg
2021-09-19 20:38 ` Marek Behún

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).